On Wed, Dec 17, 2014 at 04:41:11PM +0000, Maxim Uvarov wrote: > On 12/17/2014 07:03 PM, Stuart Haslam wrote: > > On Wed, Dec 17, 2014 at 01:57:50PM +0000, Maxim Uvarov wrote: > >> sent a patch "linux-generic: fix odp_pktio_inq_remdef" > >> please review. This patch should go before you test cases. > >> > > When I initially sent the patch I deliberately left in the failing test > > case to highlight that remdef was broken. I had assumed that failing > > test cases were OK and that they'd just be reported, as a reminder that > > something needed to be fixed. Since then we have adopted the position > > that it's unacceptable to have any failing tests as they mask other > > failures (a deficiency in the way failures are reported IMO). > > > > So we have two options, either fix the thing that's causing the failure > > or remove the test case for it. Given that the API that's failing has > > never been used, its semantics aren't well defined, that area is likely > > to change soon with the removal of ODP_PKTIO_TYPE_PKTIN/PKTOUT, and the > > desire to get these tests in this week, I would rather just remove that > > single test and get the rest of these in. Once remdef is sorted out the > > test can be reinstated at the same time as the fix. OK? > > > > -- > > Stuart. > > > I merged our both tests cases and did inq_remdef implementation. So I think > we can merge eveything together. > > Maxim. >
By the way I'm planning on sending a v3 of this patch this evening to address the comments from Anders. I've made some comments on your inq_remdef patch, it isn't ready. I still think removing the remdef test is the way to go initially so I'm going to go ahead and do that in v3. It's a tiny change to this patch and would be trivial to add it again along with the remdef fix later. -- Stuart. _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
