Merged this patch.

Maxim.

On 12/25/2014 12:28 AM, Mike Holmes wrote:


On 23 December 2014 at 06:39, Maxim Uvarov <[email protected] <mailto:[email protected]>> wrote:

    CID 85005:  Unchecked return value  (CHECKED_RETURN)
        Calling "odp_queue_enq_multi" without checking return value
        (as is done elsewhere 4 out of 5 times).

    Signed-off-by: Maxim Uvarov <[email protected]
    <mailto:[email protected]>>


Reviewed-and-Tested-by: Mike Holmes <[email protected] <mailto:[email protected]>>

    ---
     test/validation/odp_queue.c | 5 +++--
     1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/test/validation/odp_queue.c b/test/validation/odp_queue.c
    index b5ccf9a..0613fd0 100644
    --- a/test/validation/odp_queue.c
    +++ b/test/validation/odp_queue.c
    @@ -40,7 +40,7 @@ static void test_odp_queue_sunnyday(void)
            odp_buffer_pool_t msg_pool;
            odp_queue_param_t param;
            odp_buffer_t *pbuf_tmp;
    -       int i, deq_ret;
    +       int i, deq_ret, ret;
            int nr_deq_entries = 0;
            int max_iteration = CONFIG_MAX_ITERATION;
            void *prtn = NULL;
    @@ -79,7 +79,8 @@ static void test_odp_queue_sunnyday(void)
             * odp_queue_enq_multi may return 0..n buffers due to the
    resource
             * constraints in the implementation at that given point
    of time.
             */
    -       odp_queue_enq_multi(queue_id, enbuf, MAX_BUFFER_QUEUE);
    +       ret = odp_queue_enq_multi(queue_id, enbuf, MAX_BUFFER_QUEUE);
    +       CU_ASSERT(0 == ret);
            pbuf_tmp = debuf;
            do {
                    deq_ret  = odp_queue_deq_multi(queue_id, pbuf_tmp,
    --
    1.8.5.1.163.gd7aced9


    _______________________________________________
    lng-odp mailing list
    [email protected] <mailto:[email protected]>
    http://lists.linaro.org/mailman/listinfo/lng-odp




--
*Mike Holmes*
Linaro  Sr Technical Manager
LNG - ODP


_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to