Petri As discussed on the call, I will take your reviewed by forward to the v2 version if it applies and passes the tests.
Mike On 7 January 2015 at 07:41, Mike Holmes <[email protected]> wrote: > > > On 16 December 2014 at 11:40, Ola Liljedahl <[email protected]> > wrote: > >> On 16 December 2014 at 16:50, Savolainen, Petri (NSN - FI/Espoo) >> <[email protected]> wrote: >> > After renaming patches with shorter "short name" (as Mike requested): >> > >> > Reviewed-by: Petri Savolainen <[email protected]> >> > >> > >> > Patches may need to be rebased also (due to buffer patch). >> There is an updated patch coming but because of some new cunit tests >> that still used odp_core_count(). >> > > I think that we need that rebase, it does not apply for me. > Also the patch names are too long, they need to be more like 50-70 chars > and drop the description in to the description area above the > > *Signed-off-by* > --- > > >> >> > >> > >> > -Petri >> > >> > >> >> -----Original Message----- >> >> From: [email protected] [mailto:lng-odp- >> >> [email protected]] On Behalf Of ext Ola Liljedahl >> >> Sent: Monday, December 15, 2014 11:00 PM >> >> To: [email protected] >> >> Subject: [lng-odp] [PATCH 0/2] Use the term CPU instead of core >> >> >> >> (This document/code contribution attached is provided under the terms >> of >> >> agreement LES-LTM-21309) >> >> Use the term CPU instead of core in API's, messages and comments in >> >> linux-generic, examples and tests. >> >> Rename odp_core_count() to odp_cpu_count(). >> >> odp_cpu_count()/sysconf_cpu_count() reports the number of online CPU's >> >> (which may be different from the number of CONFigured CPU's, e.g. on >> b.L >> >> systems). >> >> >> >> Ola Liljedahl (2): >> >> api: odp_system_info.h: core->cpu, rename odp_core_count() to >> >> odp_cpu_count(), change "core" to "cpu"/"CPU" in messages and >> >> comments >> >> linux-generic:odp_system_info.c:sysconf_cpu_count() report online >> >> cores >> >> >> >> example/generator/odp_generator.c | 38 >> ++++++++++------- >> >> --- >> >> example/ipsec/odp_ipsec.c | 32 >> ++++++++--------- >> >> example/l2fwd/odp_l2fwd.c | 42 >> +++++++++++------ >> >> ----- >> >> example/odp_example/odp_example.c | 38 >> ++++++++++------- >> >> --- >> >> example/packet/odp_pktio.c | 40 >> ++++++++++------- >> >> ---- >> >> example/timer/odp_timer_test.c | 38 >> ++++++++++------- >> >> --- >> >> helper/include/odph_linux.h | 24 ++++++------- >> >> .../linux-generic/include/api/odp_system_info.h | 8 +++-- >> >> platform/linux-generic/include/api/odp_thread.h | 6 ++-- >> >> platform/linux-generic/odp_linux.c | 34 >> +++++++++-------- >> >> - >> >> platform/linux-generic/odp_system_info.c | 24 ++++++------- >> >> platform/linux-generic/odp_thread.c | 2 +- >> >> test/api_test/odp_atomic_test.c | 6 ++-- >> >> test/api_test/odp_common.c | 8 ++--- >> >> test/api_test/odp_ring_test.c | 2 +- >> >> test/api_test/odp_shm_test.c | 2 +- >> >> 16 files changed, 173 insertions(+), 171 deletions(-) >> >> >> >> -- >> >> 1.9.1 >> >> >> >> >> >> _______________________________________________ >> >> lng-odp mailing list >> >> [email protected] >> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > *Mike Holmes* > Linaro Sr Technical Manager > LNG - ODP > -- *Mike Holmes* Linaro Sr Technical Manager LNG - ODP
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
