On Tue, Jan 13, 2015 at 12:18 PM, Stuart Haslam <[email protected]> wrote:
> On Tue, Jan 13, 2015 at 09:49:00AM +0000, Ciprian Barbu wrote:
>> On Tue, Jan 13, 2015 at 3:50 AM, Mike Holmes <[email protected]> wrote:
>> > From the man page
>> >
>> > "The strtok() function uses a static buffer while parsing, so it's not
>> > thread safe. Use strtok_r() if this matters to you."
>> >
>> > I tested it and it appears to work fine as patched and I don't think we 
>> > need
>> > the arg parsing to be thread safe in this app as currently written.
>>
>> It can be done either way, I only saw Mike's patch about
>> _POSIX_C_SOURCE 200809L after I sent the patch. I also mistakenly
>> thought the bug was assigned to me, that's why I worked on it, but
>> it's still unclear what we are going to do with this bug. If we
>> "fixed" stdc=c99 for good by defining POSIX source then we should
>> clean all those bugs related to C99.
>>
>
> Are there other open bugs for the l2fwd, generator and ipsec examples?
> They contain a copy of the same interface name parsing code.
>
> Perhaps this code should be broken out into a shared file under
> examples/common/.

Yeah, that would be nice. But I don't have the cylces for that right now.

>
> --
> Stuart.
>

_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to