-----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of [email protected] Sent: Wednesday, January 14, 2015 6:16 PM To: [email protected] Subject: lng-odp Digest, Vol 10, Issue 108
Send lng-odp mailing list submissions to [email protected] To subscribe or unsubscribe via the World Wide Web, visit http://lists.linaro.org/mailman/listinfo/lng-odp or, via email, send a message with subject or body 'help' to [email protected] You can reach the person managing the list at [email protected] When replying, please edit your Subject line so it is more specific than "Re: Contents of lng-odp digest..." Today's Topics: 1. [PATCH] linux-generic: odp_timer.c: timer_settime usagebug (Ola Liljedahl) 2. Question on frame_len of odp_packet_t (Prashant Upadhyaya) 3. Re: Question on frame_len of odp_packet_t (Bill Fischofer) 4. Re: [PATCH] linux-generic: odp_timer.c: timer_settimeusage bug (Ola Liljedahl) 5. Re: [PATCH] linux-generic: odp_timer.c: timer_settimeusage bug (Bill Fischofer) 6. Re: [PATCH v1] api: Move Pktio related APIs to pktio Header file (Balasubramanian Manoharan) ---------------------------------------------------------------------- Message: 1 Date: Wed, 14 Jan 2015 13:11:11 +0100 From: Ola Liljedahl <[email protected]> To: [email protected] Subject: [lng-odp] [PATCH] linux-generic: odp_timer.c: timer_settime usagebug Message-ID: <[email protected]> Timerid is passed by value, not reference. Compiler cannot detect this problem because timer_t is defined as a void ptr on Linux. Signed-off-by: Ola Liljedahl <[email protected]> --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) Broken code worked anyway on x86-64 and ARMv7 targets but bug was detected on i386 target or -m32 build on x86-64 target. platform/linux-generic/odp_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_timer.c b/platform/linux-generic/odp_timer.c index ef26b02..3ba32a1 100644 --- a/platform/linux-generic/odp_timer.c +++ b/platform/linux-generic/odp_timer.c @@ -659,7 +659,7 @@ static void itimer_init(odp_timer_pool *tp) ispec.it_value.tv_sec = (time_t)sec; ispec.it_value.tv_nsec = (long)nsec; -if (timer_settime(&tp->timerid, 0, &ispec, NULL)) +if (timer_settime(tp->timerid, 0, &ispec, NULL)) ODP_ABORT("timer_settime() returned error %s\n", strerror(errno)); } -- 1.9.1 ------------------------------ Message: 2 Date: Wed, 14 Jan 2015 12:11:15 +0000 From: Prashant Upadhyaya <[email protected]> To: "[email protected]" <[email protected]> Subject: [lng-odp] Question on frame_len of odp_packet_t Message-ID: <[email protected]> Content-Type: text/plain; charset="us-ascii" Hi, I am allocating a packet with odp_packet_alloc. Now I can write some data into it using odp_packet_copydata_in. Or even by getting the buffer payload first by odp_packet_data call. But now how do I change the frame_len of this odp_packet_t ? I see a function static inline void packet_set_len(odp_packet_t pkt, uint32_t len), present in odp_packet_internal.h But I am an application so I need public access to this. I would need to send this packet out using pktio api's which inspect the frame_len of the packet. Regards -Prashant "DISCLAIMER: This message is proprietary to Aricent and is intended solely for the use of the individual to whom it is addressed. It may contain privileged or confidential information and should not be circulated or used for any purpose other than for what it is intended. If you have received this message in error, please notify the originator immediately. If you are not the intended recipient, you are notified that you are strictly prohibited from using, copying, altering, or disclosing the contents of this message. Aricent accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus." -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linaro.org/pipermail/lng-odp/attachments/20150114/1abf185c/attachment-0001.html> ------------------------------ Message: 3 Date: Wed, 14 Jan 2015 06:17:45 -0600 From: Bill Fischofer <[email protected]> To: Prashant Upadhyaya <[email protected]> Cc: "[email protected]" <[email protected]> Subject: Re: [lng-odp] Question on frame_len of odp_packet_t Message-ID: <CAKb83kYaH9MCfYidVVQcNHDL+x28vfd6RMD8j8hAtLe=z7j...@mail.gmail.com> Content-Type: text/plain; charset="utf-8" Packet length is changed as a result of doing push/pull operations on the packet head/tail. It is not something that is set explicitly by the application. For example: pkt = odp_packet_alloc(pool, len); // odp_packet_len() is len odp_packet_push_tail(pkt, nbytes); // odp_packet_len() is now len+nbytes On Wed, Jan 14, 2015 at 6:11 AM, Prashant Upadhyaya < [email protected]> wrote: > Hi, > > > > I am allocating a packet with odp_packet_alloc. > > Now I can write some data into it using odp_packet_copydata_in. Or even by > getting the buffer payload first by odp_packet_data call. > > But now how do I change the frame_len of this odp_packet_t ? > > > > I see a function static inline void packet_set_len(odp_packet_t pkt, > uint32_t len), present in odp_packet_internal.h > > > > But I am an application so I need public access to this. > > I would need to send this packet out using pktio api?s which inspect the > frame_len of the packet. > > > > Regards > > -Prashant > > > "DISCLAIMER: This message is proprietary to Aricent and is intended > solely for the use of the individual to whom it is addressed. It may > contain privileged or confidential information and should not be circulated > or used for any purpose other than for what it is intended. If you have > received this message in error, please notify the originator immediately. > If you are not the intended recipient, you are notified that you are > strictly prohibited from using, copying, altering, or disclosing the > contents of this message. Aricent accepts no responsibility for loss or > damage arising from the use of the information transmitted by this email > including damage from virus." > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linaro.org/pipermail/lng-odp/attachments/20150114/92b8ccb7/attachment-0001.html> ------------------------------ Message: 4 Date: Wed, 14 Jan 2015 13:23:05 +0100 From: Ola Liljedahl <[email protected]> To: LNG ODP Mailman List <[email protected]> Subject: Re: [lng-odp] [PATCH] linux-generic: odp_timer.c: timer_settimeusage bug Message-ID: <CAPiYAf6EEaY-Ej8jDy628Cb=m0fdex9bhvthluoymhm8r-h...@mail.gmail.com> Content-Type: text/plain; charset=UTF-8 >From the timer_settime man page: int timer_settime(timer_t timerid, int flags, const struct itimerspec *new_value, struct itimerspec * old_value); On 14 January 2015 at 13:11, Ola Liljedahl <[email protected]> wrote: > Timerid is passed by value, not reference. Compiler cannot detect this problem > because timer_t is defined as a void ptr on Linux. > > Signed-off-by: Ola Liljedahl <[email protected]> > --- > (This document/code contribution attached is provided under the terms of > agreement LES-LTM-21309) > Broken code worked anyway on x86-64 and ARMv7 targets but bug was detected on > i386 target or -m32 build on x86-64 target. > > platform/linux-generic/odp_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/platform/linux-generic/odp_timer.c > b/platform/linux-generic/odp_timer.c > index ef26b02..3ba32a1 100644 > --- a/platform/linux-generic/odp_timer.c > +++ b/platform/linux-generic/odp_timer.c > @@ -659,7 +659,7 @@ static void itimer_init(odp_timer_pool *tp) > ispec.it_value.tv_sec = (time_t)sec; > ispec.it_value.tv_nsec = (long)nsec; > > - if (timer_settime(&tp->timerid, 0, &ispec, NULL)) > + if (timer_settime(tp->timerid, 0, &ispec, NULL)) > ODP_ABORT("timer_settime() returned error %s\n", > strerror(errno)); > } > -- > 1.9.1 > ------------------------------ Message: 5 Date: Wed, 14 Jan 2015 06:44:51 -0600 From: Bill Fischofer <[email protected]> To: Ola Liljedahl <[email protected]> Cc: LNG ODP Mailman List <[email protected]> Subject: Re: [lng-odp] [PATCH] linux-generic: odp_timer.c: timer_settimeusage bug Message-ID: <cakb83kzbqazdka_jyy3p9z1fsqlwd+y9f+ewug0hd6vzdx2...@mail.gmail.com> Content-Type: text/plain; charset="utf-8" Seems like another reason to move forward with strong typing for ODP data types? On Wed, Jan 14, 2015 at 6:23 AM, Ola Liljedahl <[email protected]> wrote: > From the timer_settime man page: > int timer_settime(timer_t timerid, int flags, > const struct itimerspec *new_value, > struct itimerspec * old_value); > > On 14 January 2015 at 13:11, Ola Liljedahl <[email protected]> > wrote: > > Timerid is passed by value, not reference. Compiler cannot detect this > problem > > because timer_t is defined as a void ptr on Linux. > > > > Signed-off-by: Ola Liljedahl <[email protected]> > Reviewed-by: Bill Fischofer <[email protected]> > > --- > > (This document/code contribution attached is provided under the terms of > > agreement LES-LTM-21309) > > Broken code worked anyway on x86-64 and ARMv7 targets but bug was > detected on > > i386 target or -m32 build on x86-64 target. > > > > platform/linux-generic/odp_timer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/platform/linux-generic/odp_timer.c > b/platform/linux-generic/odp_timer.c > > index ef26b02..3ba32a1 100644 > > --- a/platform/linux-generic/odp_timer.c > > +++ b/platform/linux-generic/odp_timer.c > > @@ -659,7 +659,7 @@ static void itimer_init(odp_timer_pool *tp) > > ispec.it_value.tv_sec = (time_t)sec; > > ispec.it_value.tv_nsec = (long)nsec; > > > > - if (timer_settime(&tp->timerid, 0, &ispec, NULL)) > > + if (timer_settime(tp->timerid, 0, &ispec, NULL)) > > ODP_ABORT("timer_settime() returned error %s\n", > > strerror(errno)); > > } > > -- > > 1.9.1 > > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linaro.org/pipermail/lng-odp/attachments/20150114/c60ccbb2/attachment-0001.html> ------------------------------ Message: 6 Date: Wed, 14 Jan 2015 18:15:36 +0530 From: Balasubramanian Manoharan <[email protected]> To: Bill Fischofer <[email protected]>, "Savolainen, Petri (NSN - FI/Espoo)" <[email protected]> Cc: "[email protected]" <[email protected]> Subject: Re: [lng-odp] [PATCH v1] api: Move Pktio related APIs to pktio Header file Message-ID: <[email protected]> Content-Type: text/plain; charset="utf-8"; Format="flowed" On 14/01/15 5:28 pm, Bill Fischofer wrote: > > > On Wed, Jan 14, 2015 at 5:19 AM, Savolainen, Petri (NSN - FI/Espoo) > <[email protected] <mailto:[email protected]>> wrote: > > Reviewed-by: Petri Savolainen <[email protected] > <mailto:[email protected]>> > > A patch set (one type of modification per patch) would have been > better approach, but I'm OK with this since changes were trivial. > > > -Petri > > > > > -----Original Message----- > > From: [email protected] > <mailto:[email protected]> [mailto:lng-odp- > <mailto:lng-odp-> > > [email protected] <mailto:[email protected]>] On > Behalf Of ext Balasubramanian Manoharan > > Sent: Wednesday, January 14, 2015 8:05 AM > > To: [email protected] <mailto:[email protected]> > > Subject: [lng-odp] [PATCH v1] api: Move Pktio related APIs to > pktio Header > > file > > > > The following APIs are setting parameters to pktio handle and > are hence > > moved from classification header to pktio header file. > > odp_pktio_default_cos_set() > > odp_pktio_error_cos_set() > > odp_pktio_skip_set() > > odp_pktio_headroom_set() > > > > This patch also modifies the error return values in API description > > from -1 to non-zero value > > > > Signed-off-by: Balasubramanian Manoharan > <[email protected] <mailto:[email protected]>> > > --- > > .../linux-generic/include/api/odp_classification.h | 92 > ++++------------- > > ----- > > platform/linux-generic/include/api/odp_packet_io.h | 55 > +++++++++++++ > > .../linux-generic/include/api/odp_platform_types.h | 3 + > > platform/linux-generic/odp_classification.c | 22 +++--- > > platform/linux-generic/odp_init.c | 2 +- > > 5 files changed, 86 insertions(+), 88 deletions(-) > > > > diff --git a/platform/linux-generic/include/api/odp_classification.h > > b/platform/linux-generic/include/api/odp_classification.h > > index 4c9674b..46189bc 100644 > > --- a/platform/linux-generic/include/api/odp_classification.h > > +++ b/platform/linux-generic/include/api/odp_classification.h > > @@ -22,7 +22,6 @@ extern "C" { > > #include <odp_std_types.h> > > #include <odp_buffer_pool.h> > > #include <odp_packet.h> > > -#include <odp_packet_io.h> > > #include <odp_queue.h> > > > > /** @defgroup odp_classification ODP CLASSIFICATION > > @@ -30,11 +29,6 @@ extern "C" { > > * @{ > > */ > > > > -/** > > - * Class of service instance type > > - */ > > -typedef uint32_t odp_cos_t; > > - > > > > /** > > * flow signature type, only used for packet metadata field. > > @@ -95,7 +89,7 @@ odp_cos_t odp_cos_create(const char *name); > > * > > * @param[in] cos_id class-of-service instance. > > * > > - * @return 0 on success, -1 on error. > > + * @return 0 on success, non-zero on error. > > */ > > int odp_cos_destroy(odp_cos_t cos_id); > > > > @@ -108,7 +102,7 @@ int odp_cos_destroy(odp_cos_t cos_id); > > * of this specific class of service > > * will be enqueued. > > * > > - * @return 0 on success, -1 on error. > > + * @return 0 on success, non-zero on error. > > */ > > int odp_cos_set_queue(odp_cos_t cos_id, odp_queue_t queue_id); > > > > @@ -118,67 +112,13 @@ int odp_cos_set_queue(odp_cos_t cos_id, > odp_queue_t > > queue_id); > > * @param[in] cos_id class-of-service instance. > > * @param[in] drop_policy Desired packet drop policy > for this class. > > * > > - * @return 0 on success, -1 on error. > > + * @return 0 on success, non-zero on error. > > * > > * @note Optional. > > */ > > int odp_cos_set_drop(odp_cos_t cos_id, odp_drop_e drop_policy); > > > > /** > > - * Setup per-port default class-of-service. > > - * > > - * @param[in] pktio_in Ingress port identifier. > > - * @param[in] default_cos Class-of-service set to all > packets arriving > > - * at the pktio_in ingress port, > > - * unless overridden by subsequent > > - * header-based filters. > > - * > > - * @return 0 on success, -1 on error. > > - */ > > -int odp_pktio_set_default_cos(odp_pktio_t pktio_in, odp_cos_t > > default_cos); > > - > > -/** > > - * Setup per-port error class-of-service > > - * > > - * @param[in] pktio_in Ingress port identifier. > > - * @param[in] error_cos class-of-service set to all > packets arriving > > - * at the pktio_in ingress port > > - * that contain an error. > > - * > > - * @return 0 on success, -1 on error. > > - * > > - * @note Optional. > > - */ > > -int odp_pktio_set_error_cos(odp_pktio_t pktio_in, odp_cos_t > error_cos); > > - > > -/** > > - * Setup per-port header offset > > - * > > - * @param[in] pktio_in Ingress port identifier. > > - * @param[in] offset Number of bytes the > classifier must > > skip. > > - * > > - * @return 0 on success, -1 on error. > > - * @note Optional. > > - * > > - */ > > -int odp_pktio_set_skip(odp_pktio_t pktio_in, size_t offset); > > - > > -/** > > - * Specify per-port buffer headroom > > - * > > - * @param[in] pktio_in Ingress port identifier. > > - * @param[in] headroom Number of bytes of space > preceding > > - * packet data to reserve for use as > headroom. > > - * Must not exceed the implementation > > - * defined ODP_PACKET_MAX_HEADROOM. > > - * > > - * @return 0 on success, -1 on error. > > - * > > - * @note Optional. > > - */ > > -int odp_pktio_set_headroom(odp_pktio_t pktio_in, size_t headroom); > > - > > -/** > > * Request to override per-port class of service > > * based on Layer-2 priority field if present. > > * > > @@ -187,10 +127,10 @@ int odp_pktio_set_headroom(odp_pktio_t > pktio_in, > > size_t headroom); > > * @param[in] qos_table Values of the Layer-2 QoS > header field. > > * @param[in] cos_table Class-of-service assigned to > each of the > > * allowed Layer-2 QOS levels. > > - * @return 0 on success, -1 on error. > > + * @return 0 on success, non-zero on error. > > */ > > int odp_cos_with_l2_priority(odp_pktio_t pktio_in, > > - size_t num_qos, > > + uint8_t num_qos, > > > Is the intent here that we're limiting the potential numbers of QoS > entries to 256 or that we're limiting the number that can be set with > a single call? The latter might be reasonable, but it seems the > former is an unnecessary architectural restriction. There can only be one CoS associated with each L2 priority value per pktio interface. Hence 256 seemed a reasonable MAX limit for number of L2 priority which can be set in a single call. If more than 256 priority value needs to be set for any proprietary L2 protocol the same can be done in multiple calls. > > > uint8_t qos_table[], > > odp_cos_t cos_table[]); > > > > @@ -206,15 +146,15 @@ int odp_cos_with_l2_priority(odp_pktio_t > pktio_in, > > * @param[in] l3_preference when true, Layer-3 QoS > overrides > > * L2 QoS when present. > > * > > - * @return 0 on success, -1 on error. > > + * @return 0 on success, non-zero on error. > > * > > * @note Optional. > > */ > > int odp_cos_with_l3_qos(odp_pktio_t pktio_in, > > - size_t num_qos, > > + uint32_t num_qos, > > uint8_t qos_table[], > > odp_cos_t cos_table[], > > - bool l3_preference); > > + odp_bool_t l3_preference); > > > > > > /** > > @@ -284,7 +224,7 @@ typedef enum odp_pmr_term { > > odp_pmr_t odp_pmr_create_match(odp_pmr_term_e term, > > const void *val, > > const void *mask, > > - size_t val_sz); > > + uint32_t val_sz); > > > > /** > > * Create a packet match rule with value range > > @@ -302,13 +242,13 @@ odp_pmr_t > odp_pmr_create_match(odp_pmr_term_e term, > > odp_pmr_t odp_pmr_create_range(odp_pmr_term_e term, > > const void *val1, > > const void *val2, > > - size_t val_sz); > > + uint32_t val_sz); > > /** > > * Invalidate a packet match rule and vacate its resources > > * > > * @param[in] pmr_id Identifier of the PMR to be destroyed > > * > > - * @return 0 on success, -1 or error. > > + * @return 0 on success, non-zero or error. > > */ > > int odp_pmr_destroy(odp_pmr_t pmr_id); > > > > @@ -319,7 +259,7 @@ int odp_pmr_destroy(odp_pmr_t pmr_id); > > * @param[in] src_pktio pktio to which this PMR is > to be applied > > * @param[in] dst_cos CoS to be assigned by this PMR > > * > > - * @return 0 on success, -1 or error. > > + * @return 0 on success, non-zero or error. > > */ > > int odp_pktio_pmr_cos(odp_pmr_t pmr_id, > > odp_pktio_t src_pktio, odp_cos_t dst_cos); > > @@ -332,7 +272,7 @@ int odp_pktio_pmr_cos(odp_pmr_t pmr_id, > > * @param[in] dst_cos CoS to be assigned to > packets filtered > > * from src_cos that match pmr_id. > > * > > - * @return 0 on success, -1 on error. > > + * @return 0 on success, non-zero on error. > > */ > > int odp_cos_pmr_cos(odp_pmr_t pmr_id, odp_cos_t src_cos, odp_cos_t > > dst_cos); > > > > @@ -411,7 +351,7 @@ typedef uint32_t odp_pmr_set_t; > > * that have been successfully mapped > to the > > * underlying platform classification > engine and > > * may be in the range from 1 to > num_terms, > > - * or -1 for error. > > + * or non-zero for error. > > */ > > int odp_pmr_match_set_create(int num_terms, odp_pmr_match_t *terms, > > odp_pmr_set_t *pmr_set_id); > > @@ -429,7 +369,7 @@ int odp_pmr_match_set_create(int num_terms, > > odp_pmr_match_t *terms, > > * @param[in] pmr_set_id A composite rule-set handle > > * returned when created. > > * > > - * @return 0 on success, -1 on error. > > + * @return 0 on success, non-zero on error. > > */ > > int odp_pmr_match_set_destroy(odp_pmr_set_t pmr_set_id); > > > > @@ -441,7 +381,7 @@ int odp_pmr_match_set_destroy(odp_pmr_set_t > > pmr_set_id); > > * set is to be applied > > * @param[in] dst_cos CoS to be assigned by this > PMR match > > set > > * > > - * @return 0 on success, -1 or error. > > + * @return 0 on success, non-zero or error. > > */ > > int odp_pktio_pmr_match_set_cos(odp_pmr_set_t pmr_set_id, > odp_pktio_t > > src_pktio, > > odp_cos_t dst_cos); > > diff --git a/platform/linux-generic/include/api/odp_packet_io.h > > b/platform/linux-generic/include/api/odp_packet_io.h > > index 0c34f29..4835f4d 100644 > > --- a/platform/linux-generic/include/api/odp_packet_io.h > > +++ b/platform/linux-generic/include/api/odp_packet_io.h > > @@ -169,6 +169,61 @@ size_t odp_pktio_mac_addr(odp_pktio_t id, void > > *mac_addr, > > size_t addr_size); > > > > /** > > + * Setup per-port default class-of-service. > > + * > > + * @param[in] pktio_in Ingress port identifier. > > + * @param[in] default_cos Class-of-service set to all > packets arriving > > + * at the pktio_in ingress port, > > + * unless overridden by subsequent > > + * header-based filters. > > + * > > + * @return 0 on success, non-zero on error. > > + */ > > +int odp_pktio_default_cos_set(odp_pktio_t pktio_in, odp_cos_t > > default_cos); > > + > > +/** > > + * Setup per-port error class-of-service > > + * > > + * @param[in] pktio_in Ingress port identifier. > > + * @param[in] error_cos class-of-service set to all > packets arriving > > + * at the pktio_in ingress port > > + * that contain an error. > > + * > > + * @return 0 on success, non-zero on error. > > + * > > + * @note Optional. > > + */ > > +int odp_pktio_error_cos_set(odp_pktio_t pktio_in, odp_cos_t > error_cos); > > + > > +/** > > + * Setup per-port header offset > > + * > > + * @param[in] pktio_in Ingress port identifier. > > + * @param[in] offset Number of bytes the > classifier must > > skip. > > + * > > + * @return 0 on success, non-zero on error. > > + * @note Optional. > > + * > > + */ > > +int odp_pktio_skip_set(odp_pktio_t pktio_in, uint32_t offset); > > + > > +/** > > + * Specify per-port buffer headroom > > + * > > + * @param[in] pktio_in Ingress port identifier. > > + * @param[in] headroom Number of bytes of space > preceding > > + * packet data to reserve for use as > headroom. > > + * Must not exceed the implementation > > + * defined ODP_PACKET_MAX_HEADROOM. > > + * > > + * @return 0 on success, non-zero on error. > > + * > > + * @note Optional. > > + */ > > +int odp_pktio_headroom_set(odp_pktio_t pktio_in, uint32_t > headroom); > > + > > + > > +/** > > * @} > > */ > > > > diff --git a/platform/linux-generic/include/api/odp_platform_types.h > > b/platform/linux-generic/include/api/odp_platform_types.h > > index 0a00219..6ed9e78 100644 > > --- a/platform/linux-generic/include/api/odp_platform_types.h > > +++ b/platform/linux-generic/include/api/odp_platform_types.h > > @@ -74,6 +74,9 @@ typedef uint32_t odp_shm_t; > > #define ODP_SHM_INVALID 0 > > #define ODP_SHM_NULL ODP_SHM_INVALID /**< Synonym for buffer > pool use */ > > > > +/** ODP Class of service handle */ > > +typedef uint32_t odp_cos_t; > > + > > /** > > * @} > > */ > > diff --git a/platform/linux-generic/odp_classification.c > b/platform/linux- > > generic/odp_classification.c > > index eeb049a..7d09cce 100644 > > --- a/platform/linux-generic/odp_classification.c > > +++ b/platform/linux-generic/odp_classification.c > > @@ -256,7 +256,7 @@ int odp_cos_set_drop(odp_cos_t cos_id, > odp_drop_e > > drop_policy) > > return 0; > > } > > > > -int odp_pktio_set_default_cos(odp_pktio_t pktio_in, odp_cos_t > > default_cos) > > +int odp_pktio_default_cos_set(odp_pktio_t pktio_in, odp_cos_t > > default_cos) > > { > > pktio_entry_t *entry; > > cos_t *cos; > > @@ -275,7 +275,7 @@ int odp_pktio_set_default_cos(odp_pktio_t > pktio_in, > > odp_cos_t default_cos) > > return 0; > > } > > > > -int odp_pktio_set_error_cos(odp_pktio_t pktio_in, odp_cos_t > error_cos) > > +int odp_pktio_error_cos_set(odp_pktio_t pktio_in, odp_cos_t > error_cos) > > { > > pktio_entry_t *entry; > > cos_t *cos; > > @@ -296,7 +296,7 @@ int odp_pktio_set_error_cos(odp_pktio_t > pktio_in, > > odp_cos_t error_cos) > > return 0; > > } > > > > -int odp_pktio_set_skip(odp_pktio_t pktio_in, size_t offset) > > +int odp_pktio_skip_set(odp_pktio_t pktio_in, uint32_t offset) > > { > > pktio_entry_t *entry = get_pktio_entry(pktio_in); > > if (entry == NULL) { > > @@ -308,7 +308,7 @@ int odp_pktio_set_skip(odp_pktio_t pktio_in, > size_t > > offset) > > return 0; > > } > > > > -int odp_pktio_set_headroom(odp_pktio_t pktio_in, size_t headroom) > > +int odp_pktio_headroom_set(odp_pktio_t pktio_in, uint32_t headroom) > > { > > pktio_entry_t *entry = get_pktio_entry(pktio_in); > > if (entry == NULL) { > > @@ -320,12 +320,12 @@ int odp_pktio_set_headroom(odp_pktio_t > pktio_in, > > size_t headroom) > > } > > > > int odp_cos_with_l2_priority(odp_pktio_t pktio_in, > > - size_t num_qos, > > + uint8_t num_qos, > > uint8_t qos_table[], > > odp_cos_t cos_table[]) > > { > > pmr_l2_cos_t *l2_cos; > > - size_t i; > > + uint32_t i; > > cos_t *cos; > > pktio_entry_t *entry = get_pktio_entry(pktio_in); > > if (entry == NULL) { > > @@ -348,13 +348,13 @@ int odp_cos_with_l2_priority(odp_pktio_t > pktio_in, > > } > > > > int odp_cos_with_l3_qos(odp_pktio_t pktio_in, > > - size_t num_qos, > > + uint32_t num_qos, > > uint8_t qos_table[], > > odp_cos_t cos_table[], > > - bool l3_preference) > > + odp_bool_t l3_preference) > > { > > pmr_l3_cos_t *l3_cos; > > - size_t i; > > + uint32_t i; > > pktio_entry_t *entry = get_pktio_entry(pktio_in); > > cos_t *cos; > > > > @@ -382,7 +382,7 @@ int odp_cos_with_l3_qos(odp_pktio_t pktio_in, > > odp_pmr_t odp_pmr_create_match(odp_pmr_term_e term, > > const void *val, > > const void *mask, > > - size_t val_sz) > > + uint32_t val_sz) > > { > > pmr_t *pmr; > > odp_pmr_t id; > > @@ -410,7 +410,7 @@ odp_pmr_t > odp_pmr_create_match(odp_pmr_term_e term, > > odp_pmr_t odp_pmr_create_range(odp_pmr_term_e term, > > const void *val1, > > const void *val2, > > - size_t val_sz) > > + uint32_t val_sz) > > { > > pmr_t *pmr; > > odp_pmr_t id; > > diff --git a/platform/linux-generic/odp_init.c b/platform/linux- > > generic/odp_init.c > > index 4d0aa07..77bfd09 100644 > > --- a/platform/linux-generic/odp_init.c > > +++ b/platform/linux-generic/odp_init.c > > @@ -55,7 +55,7 @@ int odp_init_global(odp_init_t *params > ODP_UNUSED, > > return -1; > > } > > if (odp_classification_init_global()) { > > - ODP_ERR("ODP crypto init failed.\n"); > > + ODP_ERR("ODP classification init failed.\n"); > > return -1; > > } > > > > -- > > 2.0.1.472.g6f92e5f > > > > > > _______________________________________________ > > lng-odp mailing list > > [email protected] <mailto:[email protected]> > > http://lists.linaro.org/mailman/listinfo/lng-odp > > _______________________________________________ > lng-odp mailing list > [email protected] <mailto:[email protected]> > http://lists.linaro.org/mailman/listinfo/lng-odp > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linaro.org/pipermail/lng-odp/attachments/20150114/50ed40e4/attachment.html> ------------------------------ _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp End of lng-odp Digest, Vol 10, Issue 108 **************************************** "DISCLAIMER: This message is proprietary to Aricent and is intended solely for the use of the individual to whom it is addressed. It may contain privileged or confidential information and should not be circulated or used for any purpose other than for what it is intended. If you have received this message in error, please notify the originator immediately. If you are not the intended recipient, you are notified that you are strictly prohibited from using, copying, altering, or disclosing the contents of this message. Aricent accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus." _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
