I haven't seen a v4. v3 is the latest level of the patch I've seen on the list. Do we need a hangout to sort this out?
On Fri, Jan 16, 2015 at 10:01 AM, Mike Holmes <[email protected]> wrote: > I only tried V4 not V3, I think there is some platform or procedure > difference we are looking for, I tried with the script and in my own > sandbox > > checkpatch fails on whitepsace > Using patch: > lng-odp_PATCH_v4_1-2_linux-generic_Implement_odp_atomic_tptr_t_opaque_type_to_avoid_ABA_problems_on_fast_non-deterministic_systems.mbox > Trying to apply patch > Patch applied > ERROR: code indent should use tabs where possible > #175: FILE: platform/linux-generic/include/odp_atomic_internal.h:526: > +^I^I^I^I _odp_memmodel_t mmodel)$ > > If I ignore the white space error I get > > odp_packet_socket.c: In function 'mmap_setup_ring': > odp_packet_socket.c:631:2: error: implicit declaration of function > 'rpl_malloc' [-Werror=implicit-function-declaration] > ring->rd = malloc(ring->rd_len); > ^ > odp_packet_socket.c:631:2: error: nested extern declaration of > 'rpl_malloc' [-Werror=nested-externs] > odp_packet_socket.c:631:11: error: assignment makes pointer from integer > without a cast [-Werror] > ring->rd = malloc(ring->rd_len); > > * 6139ef0 :2015-01-16 - (HEAD, master) linux-generic: Implement > _odp_atomic_tptr_t opaque type to avoid ABA problems on fast non-determini > * c068836 :2015-01-16 - (origin/master, origin/HEAD) Update version number > from 0.7.0 to 0.8.0 <Maxim Uvarov> > * 38e36ef :2015-01-14 - helper: linux: use cpumask in linux thread/proc > <Robbie King> > * 5e47a0c :2015-01-14 - helper: linux: add odph_linux_cpumask_default > <Robbie King> > > Linux mike-desktop 3.16.0-29-generic #39-Ubuntu SMP Mon Dec 15 22:27:29 > UTC 2014 x86_64 x86_64 x86_64 GNU/Linux > > history > 2114 git clean -xdf > 2115 git am ~/incoming/lng-odp_PATCH_v4_1-2_* > 2116 make clean > 2117 ./bootstrap > 2118 ./configure --with-cunit-path=/home/mike/CUnitHome > 2119 make > > > > On 16 January 2015 at 10:34, Bill Fischofer <[email protected]> > wrote: > >> I just cloned a fresh sandbox and confirmed that both patches still apply >> and build for me as of this morning. Anders: The errors you're showing in >> odp_packet_socket.c are strange as the patch doesn't touch that module. >> Are you sure you don't have any local mods that may be conflicting? >> >> On Fri, Jan 16, 2015 at 9:21 AM, Geoffrey Blake <[email protected]> >> wrote: >> >>> I'm using an Ubuntu 14.04LTS x86_64 box for development and last pulled >>> the public repo 2 days ago to refactor this patch according to my log, so I >>> am a bit surprised the patches are not cleanly applying for you. >>> >>> -Geoff >>> >>> -----Original Message----- >>> From: Anders Roxell [mailto:[email protected]] >>> Sent: Friday, January 16, 2015 9:06 AM >>> To: Bill Fischofer >>> Cc: Geoffrey Blake; LNG ODP Mailman List >>> Subject: Re: [lng-odp] [PATCH v3 1/2] linux-generic: Implement >>> _odp_atomic_tptr_t opaque type to avoid ABA problems on fast >>> non-deterministic systems >>> >>> On 2015-01-15 18:53, Bill Fischofer wrote: >>> > This patch has trailing whitespace errors which should be corrected. >>> > Other than that: >>> > >>> > On Thu, Jan 15, 2015 at 3:59 PM, Geoffrey Blake >>> > <[email protected]> >>> > wrote: >>> > >>> > > From: Geoffrey Blake <[email protected]> >>> > > >>> > > Re-factor the patch to create an opaque tagged pointer type for 32 >>> > > and 64bit architectures with large tags to avoid the ABA problem. >>> > > Compiles cleanly under >>> > > x86_64 and i386 and passes some basic tests. Need to perform more >>> > > rigorous stress testing still. >>> > > >>> > > Signed-off-by: Geoffrey Blake <[email protected]> >>> > > >>> > >>> > Reviewed-and-tested-by: Bill Fischofer <[email protected]> >>> >>> Geoffrey and Bill, >>> >>> What's your setup? >>> >>> I couldn't get this patch to build, acctually I couldn't get the second >>> patch to build either. >>> >>> Cheers, >>> Anders >>> >>> odp_packet_socket.c: In function 'mmap_setup_ring': >>> odp_packet_socket.c:631:2: error: implicit declaration of function >>> 'rpl_malloc' [-Werror=implicit-function-declaration] >>> ring->rd = malloc(ring->rd_len); >>> ^ >>> odp_packet_socket.c:631:2: error: nested extern declaration of >>> 'rpl_malloc' [-Werror=nested-externs] >>> odp_packet_socket.c:631:11: error: assignment makes pointer from integer >>> without a cast [-Werror] >>> ring->rd = malloc(ring->rd_len); >>> ^ >>> cc1: all warnings being treated as errors >>> Makefile:584: recipe for target 'odp_packet_socket.lo' failed >>> make[2]: *** [odp_packet_socket.lo] Error 1 >>> make[2]: *** Waiting for unfinished jobs.... >>> make[2]: Leaving directory >>> '/home/anders/src/crap.odp/platform/linux-generic' >>> Makefile:369: recipe for target 'all-recursive' failed >>> make[1]: *** [all-recursive] Error 1 >>> make[1]: Leaving directory '/home/anders/src/crap.odp/platform' >>> Makefile:454: recipe for target 'all-recursive' failed >>> make: *** [all-recursive] Error 1 >>> >>> >>> >>> >>> >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> > > > -- > *Mike Holmes* > Linaro Sr Technical Manager > LNG - ODP >
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
