Thanks for the review Petri. A short comment inlined.
On 20/01/2015 13:38, "Savolainen, Petri (NSN - FI/Espoo)"
<[email protected]> wrote:
>
>> --- /dev/null
>> +++ b/platform/linux-generic/include/api/odp_errno.h
>> @@ -0,0 +1,61 @@
>> +/* Copyright (c) 2015, Linaro Limited
>> + * All rights reserved.
>> + *
>> + * SPDX-License-Identifier: BSD-3-Clause
>> + */
>> +
>> +/**
>> + * @file
>> + *
>> + * ODP errno API
>> + */
>> +
>> +#ifndef ODP_ERRNO_H_
>> +#define ODP_ERRNO_H_
>> +
>> +#ifdef __cplusplus
>> +extern "C" {
>> +#endif
>> +
>> +#include <errno.h>
>
>This should be removed from API file (only implementation needs it).
That¹s there so that both ODP libraries and applications using them can
see the errno error definitions. Otherwise things like ³EEXIST² etc will
give compile errors. The alternative would be to include both
<odp_errno.h> and <errno.h> in implementation files and applications.
Which option should we go with?
>
>> +
>> +/**
>> +* Return latest ODP errno
>> +*
>> +* @retval 0 == no error
>
>@return ODP errno
>@retval 0 No error
>
>It's likely that "==" would not look good on Doxygen doc. It's from my
>mail, sorry about that.
>
>-Petri
>
>> +*/
>> +int odp_errno(void);
>> +
>
-- IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered
in England & Wales, Company No: 2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ,
Registered in England & Wales, Company No: 2548782
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
