I'd agree if it's to be added it should be to the odp helper file.

On Tue, Jan 20, 2015 at 9:00 AM, Mike Holmes <[email protected]> wrote:

> On 20 January 2015 at 09:52, Jerin Jacob <[email protected]>
> wrote:
>
>> On Mon, Jan 19, 2015 at 06:49:35PM +0300, Maxim Uvarov wrote:
>> > On 01/19/2015 02:44 PM, Jerin Jacob wrote:
>> > >Signed-off-by: Jerin Jacob <[email protected]>
>> > >---
>> > >  helper/include/odph_ip.h | 1 +
>> > >  1 file changed, 1 insertion(+)
>> > >
>> > >diff --git a/helper/include/odph_ip.h b/helper/include/odph_ip.h
>> > >index 272fd96..f2638ba 100644
>> > >--- a/helper/include/odph_ip.h
>> > >+++ b/helper/include/odph_ip.h
>> > >@@ -167,6 +167,7 @@ typedef struct ODP_PACKED {
>> > >  #define ODPH_IPPROTO_FRAG    0x2C /**< IPv6 Fragment (44) */
>> > >  #define ODPH_IPPROTO_AH      0x33 /**< Authentication Header (51) */
>> > >  #define ODPH_IPPROTO_ESP     0x32 /**< Encapsulating Security
>> Payload (50) */
>> > >+#define ODPH_IPPROTO_SCTP    0x84 /**< Stream Control Transmission
>> (132) */
>> > >  #define ODPH_IPPROTO_INVALID 0xFF /**< Reserved invalid by IANA */
>> > >  /**@}*/
>> > We planned to remove IP stucturues and defines from ODP headers and use
>> > systems.
>> > If for now nobody uses that define can you, in your case use it from:
>> > /usr/include/netinet/in.h
>>
>> Including the system header files in bare metal build
>> is bit difficult as it has lot dependency.
>>
>>
> I wonder if any decision to reuse  /usr/include/netinet/in.h is wise, we
> have been removing assert, errno and compiler specifics from the public
> API, it would appear this is an extension to that.
>
>
>>
>> > IPPROTO_SCTP = 132,    /* Stream Control Transmission Protocol.  */
>> >
>> > Regards,
>> > Maxim.
>> >
>> >
>> >
>> > _______________________________________________
>> > lng-odp mailing list
>> > [email protected]
>> > http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>> _______________________________________________
>> lng-odp mailing list
>> [email protected]
>> http://lists.linaro.org/mailman/listinfo/lng-odp
>>
>
>
>
> --
> *Mike Holmes*
> Linaro  Sr Technical Manager
> LNG - ODP
>
> _______________________________________________
> lng-odp mailing list
> [email protected]
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
>
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to