Despite build issues difference still to track down, I see these new Doxygen issues with the patches fully applied, do you see these Bill ?
/home/mike/git/odp/platform/linux-generic/include/api/odp_event.h:47: warning: Member ODP_EVENT_TIMEOUT (macro definition) of group odp_event is not documented. /home/mike/git/odp/platform/linux-generic/include/api/odp_pool.h:79: warning: Member ODP_POOL_TIMEOUT (macro definition) of group odp_buffer is not documented. /home/mike/git/odp/platform/linux-generic/include/api/odp_pool.h:79: warning: Member ODP_POOL_TIMEOUT (macro definition) of group odp_buffer is not documented. /home/mike/git/odp/platform/linux-generic/include/api/odp_event.h:47: warning: Member ODP_EVENT_TIMEOUT (macro definition) of group odp_event is not documented. On 21 January 2015 at 16:28, Bill Fischofer <[email protected]> wrote: > This patch series applies and builds fine for me. There are a few > checkpatch warnings about lines over 80 chars. Most of them are cleaned up > in subsequent patches, however odp_schedule.c is still over the limit. > Fixing it results in profoundly ugly wrapping as the code being flagged is > several 8-byte indents deep to start with. If you wanted it to look > pretty, you'd really want to restructure the code to eliminate the stair > stepping. > > But aside from that: > > Reviewed-and-tested-by: Bill Fischofer <[email protected]> > > On Wed, Jan 21, 2015 at 9:49 AM, Mike Holmes <[email protected]> > wrote: > >> I saw some issues but then buffers segfaulted after the application >> of lng-odp_PATCH_v3_15-16_api_config_Renamed_ODP_CONFIG_BUFFER_POOLS.mbox, >> prior to that it just failed and did not segfault. >> >> On 21 January 2015 at 10:15, Petri Savolainen < >> [email protected]> wrote: >> >>> This patch set introduces odp_event_t. It replaces odp_buffer_t in many >>> places >>> with odp_event_t. Events are the objects that are transimitted by and >>> scheduled >>> from queues. Event is the new "super class" for various events (buffers, >>> packets, timeouts, etc). Various event types can be converted to >>> odp_event_t >>> (and back), but not to another event type. >>> >>> Buffer pool is also changed to a generic "pool". Pool and event types >>> have >>> been separated. There are matching pool types for buffer, packet and >>> timeout >>> events (as "buffer types" before). Later on, there can be event types >>> without >>> a matching pool type, and pool types without a matching event type. >>> >>> Some lines are over 80 chars. Those are mainly caused by temporary >>> event <-> buffer, packet -> event -> buffer conversions and should be >>> cleaned up >>> from the implementation. This patch set does minimal implementation >>> changes. >>> >>> >>> v2 >>> * Updated validation test suite to use events >>> >>> v3 >>> * Fixed bugs that crashed validation test cases >>> * Breaked over 80 char lines where possible (without re-implementation) >>> >>> >>> Petri Savolainen (16): >>> api: event: Add odp_event_t >>> api: event: odp_schedule and odp_queue_enq >>> api: event: schedule_multi and queue_enq_multi >>> api: event: odp_queue_deq >>> api: event: odp_queue_deq_multi >>> api: buffer: Removed odp_buffer_type >>> api: packet: Removed odp_packet_to_buffer >>> api: packet: Removed odp_packet_from_buffer >>> api: timer: Use odp_event_t instead of odp_buffer_t >>> api: crypto: Use odp_event_t instead of odp_buffer_t >>> linux-generic: crypto: Use packet alloc for packet >>> api: buffer_pool: Rename odp_buffer_pool.h to odp_pool.h >>> api: pool: Rename pool params and remove buffer types >>> api: pool: Rename odp_buffer_pool_ to odp_pool_ >>> api: config: Renamed ODP_CONFIG_BUFFER_POOLS >>> api: timer: Added timeout alloc and free >>> >>> example/generator/odp_generator.c | 38 ++-- >>> example/ipsec/odp_ipsec.c | 70 +++---- >>> example/ipsec/odp_ipsec_cache.c | 4 +- >>> example/ipsec/odp_ipsec_cache.h | 2 +- >>> example/ipsec/odp_ipsec_loop_db.c | 2 +- >>> example/ipsec/odp_ipsec_loop_db.h | 12 +- >>> example/ipsec/odp_ipsec_stream.c | 20 +- >>> example/ipsec/odp_ipsec_stream.h | 2 +- >>> example/l2fwd/odp_l2fwd.c | 28 +-- >>> example/packet/odp_pktio.c | 29 ++- >>> example/timer/odp_timer_test.c | 76 ++++---- >>> platform/linux-generic/Makefile.am | 4 +- >>> platform/linux-generic/include/api/odp.h | 3 +- >>> platform/linux-generic/include/api/odp_buffer.h | 41 ++-- >>> .../linux-generic/include/api/odp_buffer_pool.h | 177 >>> ----------------- >>> .../linux-generic/include/api/odp_classification.h | 2 +- >>> platform/linux-generic/include/api/odp_config.h | 4 +- >>> platform/linux-generic/include/api/odp_crypto.h | 16 +- >>> platform/linux-generic/include/api/odp_event.h | 59 ++++++ >>> platform/linux-generic/include/api/odp_packet.h | 29 +-- >>> platform/linux-generic/include/api/odp_packet_io.h | 4 +- >>> .../linux-generic/include/api/odp_platform_types.h | 10 +- >>> platform/linux-generic/include/api/odp_pool.h | 203 >>> ++++++++++++++++++++ >>> platform/linux-generic/include/api/odp_queue.h | 32 ++-- >>> platform/linux-generic/include/api/odp_schedule.h | 32 ++-- >>> platform/linux-generic/include/api/odp_timer.h | 91 ++++++--- >>> .../linux-generic/include/odp_buffer_inlines.h | 6 +- >>> .../linux-generic/include/odp_buffer_internal.h | 20 +- >>> .../include/odp_buffer_pool_internal.h | 22 +-- >>> .../linux-generic/include/odp_crypto_internal.h | 2 +- >>> .../linux-generic/include/odp_packet_internal.h | 8 +- >>> platform/linux-generic/include/odp_packet_socket.h | 10 +- >>> platform/linux-generic/odp_buffer.c | 12 +- >>> platform/linux-generic/odp_buffer_pool.c | 141 +++++++------- >>> platform/linux-generic/odp_crypto.c | 36 ++-- >>> platform/linux-generic/odp_event.c | 19 ++ >>> platform/linux-generic/odp_packet.c | 34 ++-- >>> platform/linux-generic/odp_packet_io.c | 22 +-- >>> platform/linux-generic/odp_packet_socket.c | 10 +- >>> platform/linux-generic/odp_queue.c | 18 +- >>> platform/linux-generic/odp_schedule.c | 50 ++--- >>> platform/linux-generic/odp_timer.c | 55 ++++-- >>> test/performance/odp_scheduling.c | 105 +++++----- >>> test/validation/buffer/odp_buffer_pool_test.c | 213 >>> ++++++++++++--------- >>> test/validation/buffer/odp_buffer_test.c | 26 +-- >>> test/validation/buffer/odp_buffer_tests.h | 2 +- >>> test/validation/buffer/odp_packet_test.c | 50 ++--- >>> test/validation/crypto/odp_crypto_test_async_inp.c | 43 ++--- >>> test/validation/crypto/odp_crypto_test_sync_inp.c | 11 +- >>> test/validation/odp_crypto.c | 28 +-- >>> test/validation/odp_pktio.c | 79 ++++---- >>> test/validation/odp_queue.c | 50 ++--- >>> test/validation/odp_schedule.c | 44 +++-- >>> test/validation/odp_timer.c | 90 +++++---- >>> 54 files changed, 1245 insertions(+), 951 deletions(-) >>> delete mode 100644 platform/linux-generic/include/api/odp_buffer_pool.h >>> create mode 100644 platform/linux-generic/include/api/odp_event.h >>> create mode 100644 platform/linux-generic/include/api/odp_pool.h >>> create mode 100644 platform/linux-generic/odp_event.c >>> >>> -- >>> 2.2.2 >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> [email protected] >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> >> -- >> *Mike Holmes* >> Linaro Sr Technical Manager >> LNG - ODP >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> > -- *Mike Holmes* Linaro Sr Technical Manager LNG - ODP
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
