On 28 January 2015 at 16:23, Taras Kondratiuk <[email protected]> wrote: > On 01/28/2015 02:02 PM, Mike Holmes wrote: >> >> I only ran it so far, there is a lot to look at :) >> I think Taras is actually basing his work on these changes as they make >> managing a platform easier, his comment will be valuable. > > > The series is fine. There is one thing that confuses me a bit: > <odp_root>/include/odp/api directory contains function prototypes now. > But we still have platform/linux-generic/include/api/odp directory. > Having both 'odp/api' and 'api/odp' is confusing. I think 'api' part > can be dropped from platform include path. Public headers will be placed in > platform/linux-generic/include/odp. > > Also some files are missing @file and @ingroup doxygen tags, but it can be > fixed later in an incremental way when this massive change is merged.
Thank for your comments. New pull request sent. Cheers, Anders _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
