On Fri, Jan 30, 2015 at 04:45:56PM +0000, Mike Holmes wrote: > Sorry, should be ODP_WEAK_SYMBOL, not sure where my mind was.
Ah OK, that change would make more sense :) -- Stuart. > > On 30 January 2015 at 11:39, Stuart Haslam > <[email protected]<mailto:[email protected]>> wrote: > On Fri, Jan 30, 2015 at 01:54:40PM +0000, Mike Holmes wrote: > > Signed-off-by: Mike Holmes > > <[email protected]<mailto:[email protected]>> > > --- > > platform/linux-generic/odp_packet_socket.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/platform/linux-generic/odp_packet_socket.c > > b/platform/linux-generic/odp_packet_socket.c > > index 3f114fa..0fda129 100644 > > --- a/platform/linux-generic/odp_packet_socket.c > > +++ b/platform/linux-generic/odp_packet_socket.c > > @@ -48,7 +48,8 @@ > > * As it is implemented as a weak symbol, it has zero effect on systems > > * with both. > > */ > > -int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int > > flags) __attribute__((weak)); > > +int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int > > flags) > > + ODP_UNUSED; > > int sendmmsg(int fd, struct mmsghdr *vmessages, unsigned int vlen, int > > flags) > > { > > #ifdef SYS_sendmmsg > > I'm not sure why this change is needed. The function is used. Also why > are you dropping the weak attribute? > > -- > Stuart. _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
