On 02/04/2015 06:40 PM, Savolainen, Petri (NSN - FI/Espoo) wrote:
Hi,
I sent out review comments for patches: 1, 2, 5, 8, 11, 14, 16.
Other than those can be merged already (if possible without conflicts).
Hopefully those can be merged ASAP so that other patches (on the list) can be
rebased on that.
For patches: 3, 4, 6, 7, 9, 10, 12, 13, 15, 17, 18.
Reviewed-by: Petri Savolainen <[email protected]>
Reviewed patches has been merged!
Maxim.
-Petri
-----Original Message-----
From: [email protected] [mailto:lng-odp-
[email protected]] On Behalf Of ext Ola Liljedahl
Sent: Tuesday, February 03, 2015 6:48 PM
To: [email protected]
Subject: [lng-odp] [PATCHv5 00/18] Cleanup return semantics and
descriptions
Changes since version 4:
Restored parameter names of odp_cpumask_to_str(), odp_pktio_mac_addr()
and +odp_hw_random_get().
Changes since version 3:
Removed unnecessary braces from odp_cpumask.c in patch #1.
Changes since version 2:
Rebased, e.g. due to API restructuring.
Split two patches, separating documentation updates from API changes.
Reordered patches, all serious API changes are now contained in patches 1-
4.
Patches #1-#3:
odp_cpumask_to_str(), odp_pktio_mac_addr() and odp_hw_random_get() takes
output buffer size as input and returns number of chars/bytes written (on
success), a negative value on failure.
Added defines (ODP_CPUMASK_BUFSIZE, ODP_PKTIO_MACADDRSIZE) for recommended
output buffer sizes.
Updated the implementations of these calls.
Updated all usages of these calls in example and test programs.
Patch #4:
Changed the definition of odp_queue_enq_multi() to support partial success
(e.g. enqueued some but not all of the events specified). Returns the
number
of events enqueued (equivalent to odp_queue_deq_multi()). This change is
necessary to support ODP implementations that use fixed size queues (e.g.
ODP linux-dpdk).
Updated the implementation in odp_queue.c to conform to the new semantics.
Updated the necessary test/validation/performance programs.
Patches #5-#18:
Updated doxygen descriptions, particularly the @return/@retval
descriptions.
Specifically documented those API calls which are guaranteed to handle
invalid/stale handles.
No change of implementation necessary.
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Ola Liljedahl (18):
api: odp_cpumask.h: odp_cpumask_to_str() return chars written or error
api: odp_pktio.h: odp_pktio_mac_addr() return chars written or error
api: odp_crypto.h: odp_hw_random_get(): return number of bytes written
api: odp_queue.h: odp_queue_enq_multi() returns partial success
api: odp_buffer.h: undefined behavior description
api: odp_byteorder.h: updated comment
api: odp_classification.h: updated return descriptions
api: odp_init.h: updated return descriptions
api: odp_packet.h: updated return descriptions
api: odp_packet_flags.h: updated return descriptions
api: odp_packet_io.h: updated return descriptions
api: odp_queue.h: updated return descriptions
api: odp_schedule.h: updated return descriptions
api: odp_shared_memory.h: updated return descriptions
api: odp_thread.h: updated return descriptions
api: odp_timer.h: updated return descriptions
api: odp_cpumask.h: updated descriptions, added const
api: odp_crypto.h: updated return descriptions
example/generator/odp_generator.c | 4 +-
example/ipsec/odp_ipsec.c | 4 +-
example/ipsec/odp_ipsec_cache.c | 6 +-
example/l2fwd/odp_l2fwd.c | 4 +-
example/packet/odp_pktio.c | 4 +-
example/timer/odp_timer_test.c | 4 +-
include/odp/api/buffer.h | 4 +-
include/odp/api/byteorder.h | 2 +-
include/odp/api/classification.h | 48 ++++----
include/odp/api/cpumask.h | 123 +++++++++++++---
-----
include/odp/api/crypto.h | 23 ++--
include/odp/api/init.h | 20 ++--
include/odp/api/packet.h | 68 ++++++------
include/odp/api/packet_flags.h | 51 ++++++---
include/odp/api/packet_io.h | 109 ++++++++++------
--
include/odp/api/queue.h | 38 ++++---
include/odp/api/schedule.h | 3 +-
include/odp/api/shared_memory.h | 17 +--
include/odp/api/thread.h | 6 +-
include/odp/api/timer.h | 52 +++------
.../linux-generic/include/odp/plat/cpumask_types.h | 5 +
.../include/odp/plat/packet_io_types.h | 2 +
platform/linux-generic/odp_cpumask.c | 38 ++++---
platform/linux-generic/odp_crypto.c | 8 +-
platform/linux-generic/odp_packet_io.c | 15 +--
platform/linux-generic/odp_queue.c | 4 +-
test/api_test/odp_common.c | 4 +-
test/performance/odp_scheduling.c | 14 ++-
test/validation/crypto/odp_crypto_test_rng.c | 6 +-
test/validation/odp_pktio.c | 24 ++--
test/validation/odp_queue.c | 3 +-
31 files changed, 408 insertions(+), 305 deletions(-)
--
1.9.1
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
