Reviewed-by: Anders Roxell <[email protected]> For this patch set.
On 2015-02-05 09:15, Ola Liljedahl wrote: > Changes since version 4: > Moved change of printf to LOG_DBG from patch #1 to patch #4. > > Changes since version 3: > Split out patch #6 from patch #4. > > Miscellaneous cleanup of test/validation/odp_timer.c. > > Patch #1: > Don't report late timeouts using CU_FAIL as this interferes with the cunit > test framework. Just count and report the number of late timeouts. > > Patch #2: > Don't dereference pointer after successful check for NULL as this makes > Coverity > complain. (Coverity CID 85397, https://bugs.linaro.org/show_bug.cgi?id=1056) > > Patch #3: > Use nanosleep instead of the deprecated usleep. Define POSIX version to be > able > to use rand_r. (https://bugs.linaro.org/show_bug.cgi?id=1048) > > Patch #4: > Use CU_ASSERT_FATAL instead of plain assert so to work better with the cunit > test framework. > Use LOG_DBG instead of printf. Remove some unnecessary printouts. > > Patch #5: > Replace usage of perror and abort with CU_FAIL_FATAL in order for fatal > errors not to disturb the overall validation flow. > > Patch #6: > Ensure we run at least one worker thread. > > (This document/code contribution attached is provided under the terms of > agreement LES-LTM-21309) > > Ola Liljedahl (6): > validation: odp_timer.c: avoid cunit warnings for late timeouts > validation: odp_timer.c: avoid dereferencing ptr after NULL check > validation: odp_timer.c: use nanosleep instead of usleep > validation: odp_timer.c: cunit cleanup Replace printf with > LOG_DBG. > validation: odp_timer.c: remove usage of perror/abort > validation: odp_timer.c: run at least one thread > > test/validation/odp_timer.c | 105 > +++++++++++++++++++++++++------------------- > 1 file changed, 60 insertions(+), 45 deletions(-) > > -- > 1.9.1 > > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp -- Anders Roxell [email protected] M: +46 709 71 42 85 | IRC: roxell _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
