I believe the correct fix should be to add a new error code, ODP_CRYPTO_ALG_ERR_KEY_SIZE is not appropriate for the detected error. Please add the following to crypto_alg_err and return it instead. This would happen when the session is created without specifying an IV value, and then on a per packet basis it is not passing the IV value either (using override_iv_ptr).
ODP_CRYPTO_ALG_ERR_IV_INVALID /**< IV value not specified */ -----Original Message----- From: Maxim Uvarov [mailto:[email protected]] Sent: Tuesday, February 17, 2015 4:30 PM To: [email protected] Cc: Robbie King (robking); Alexandru Badicioiu; Maxim Uvarov Subject: Re: [lng-odp] [PATCH 3/5] linux-generic: crypto: fix crypto_alg_err enum return values Robbie, Alex, please review that patch. Maxim. On 02/04/2015 03:00 PM, Taras Kondratiuk wrote: > Signed-off-by: Taras Kondratiuk <[email protected]> > --- > platform/linux-generic/odp_crypto.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/platform/linux-generic/odp_crypto.c > b/platform/linux-generic/odp_crypto.c > index 46766fa..fa7d51f 100644 > --- a/platform/linux-generic/odp_crypto.c > +++ b/platform/linux-generic/odp_crypto.c > @@ -160,7 +160,7 @@ enum crypto_alg_err des_encrypt(odp_crypto_op_params_t > *params, > else if (session->cipher.iv.data) > iv_ptr = session->cipher.iv.data; > else > - return ODP_CRYPTO_SES_CREATE_ERR_INV_CIPHER; > + return ODP_CRYPTO_ALG_ERR_KEY_SIZE; > > /* > * Create a copy of the IV. The DES library modifies IV > @@ -198,7 +198,7 @@ enum crypto_alg_err des_decrypt(odp_crypto_op_params_t > *params, > else if (session->cipher.iv.data) > iv_ptr = session->cipher.iv.data; > else > - return ODP_CRYPTO_SES_CREATE_ERR_INV_CIPHER; > + return ODP_CRYPTO_ALG_ERR_KEY_SIZE; > > /* > * Create a copy of the IV. The DES library modifies IV _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
