For this patch series:
Reviewed-and-tested-by: Bill Fischofer <[email protected]>

Note that while this patch is OK, now that the termination functions are
present it exposes deficiencies in a number of the validation tests in that
they don't properly clean up after themselves.  For example, tests fail
because queues have unconsumed events on them (so queues can't be destroyed
as part of termination) and pools can't be destroyed because they contain
allocated buffers. These tests really should properly clean up after
themselves so that they terminate normally.

Tests that seem to have issues include:

odp_pktio
odp_classification
odp_queue
odp_schedule
odp_crypto

On Mon, Feb 23, 2015 at 2:35 PM, Robbie King <[email protected]> wrote:

> v3:
> Termination routines now continue despite failures.
> Also added some debugging code to aid in root
> causing scheduler termination issues.
>
> v2:
> Addresses the only comment to replace
> static const char shm_name[] ....
> with
> const char SHM_DEFAULT_NAME[]
>
> Yan Sonming (10):
>   linux-generic: classification: add term_global
>   linux-generic: odp_crypto: add term_global
>   linux-generic: packet_io: add term_global
>   linux-generic: schedule: add term_global
>   linux-generic: queue: add term_global
>   linux-generic: buffer_pool: add term_global
>   linux-generic: thread: add term_global
>   linux-generic: shm: add term_global
>   linux-generic: schedule: add term_local
>   linux-generic: buffer pool: add term_local
>
>  platform/linux-generic/include/odp_internal.h | 10 ++++
>  platform/linux-generic/odp_classification.c   | 26 ++++++++++
>  platform/linux-generic/odp_crypto.c           | 11 +++++
>  platform/linux-generic/odp_init.c             | 69
> +++++++++++++++++++++++++--
>  platform/linux-generic/odp_packet_io.c        | 18 +++++++
>  platform/linux-generic/odp_pool.c             | 36 +++++++++++++-
>  platform/linux-generic/odp_queue.c            | 38 ++++++++++++++-
>  platform/linux-generic/odp_schedule.c         | 34 +++++++++++++
>  platform/linux-generic/odp_shared_memory.c    |  8 ++++
>  platform/linux-generic/odp_thread.c           | 11 +++++
>  10 files changed, 255 insertions(+), 6 deletions(-)
>
> --
> 1.9.3
>
>
> _______________________________________________
> lng-odp mailing list
> [email protected]
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to