On 02/26/2015 01:10 AM, Mike Holmes wrote:
Why is this merged - I have undressed comments ?
>/**
> + * @def ODP_PMR_INVAL
> + * Invalid odp_pmr_t value.
> + * This value is returned from odp_pmr_create_match() and
> + * odp_pmr_create_range() functions on failure.
Is listing the function names a good idea, what this gets returned
form another func in future, will it get updated ?
Looks like I did not understand if it's simple question or request to
rework.
> + * @def ODP_PMR_SET_INVAL
> + * Invalid odp_pmr_set_t value.
The comment on ODP_PMR_IVAL gives a greater indication what the
definition is used for, the text here does not add anything or
CrossRef to further information, can this have a better description
in some way ?
That comment is in quoted area at least in Thunderbird.
But I think Bala just follow other code. The same thing we have for
ODP_POOL_INVALID for example.
Maxim.
On 25 February 2015 at 04:33, Maxim Uvarov <[email protected]
<mailto:[email protected]>> wrote:
Merged,
Maxim.
On 02/23/2015 05:18 PM, [email protected]
<mailto:[email protected]> wrote:
From: Balasubramanian Manoharan <[email protected]
<mailto:[email protected]>>
Adds documentation for ODP_PMR_INVAL and ODP_PMR_SET_INVAL macros
https://bugs.linaro.org/show_bug.cgi?id=1208
Signed-off-by: Balasubramanian Manoharan
<[email protected] <mailto:[email protected]>>
---
include/odp/api/classification.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/include/odp/api/classification.h
b/include/odp/api/classification.h
index 8758fb5..7db3645 100644
--- a/include/odp/api/classification.h
+++ b/include/odp/api/classification.h
@@ -48,6 +48,18 @@ extern "C" {
*/
/**
+ * @def ODP_PMR_INVAL
+ * Invalid odp_pmr_t value.
+ * This value is returned from odp_pmr_create_match() and
+ * odp_pmr_create_range() functions on failure.
+ */
+
+/**
+ * @def ODP_PMR_SET_INVAL
+ * Invalid odp_pmr_set_t value.
+ */
+
+/**
* Class-of-service packet drop policies
*/
typedef enum odp_cos_drop {
_______________________________________________
lng-odp mailing list
[email protected] <mailto:[email protected]>
http://lists.linaro.org/mailman/listinfo/lng-odp
--
*Mike Holmes*
Linaro Sr Technical Manager
LNG - ODP
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp
