Nice cleanup, makes it easier to move to per test initialization/termination.
Reviewed-by: Robert King <[email protected]> -----Original Message----- From: Taras Kondratiuk [mailto:[email protected]] Sent: Thursday, February 26, 2015 6:19 PM To: [email protected] Cc: [email protected]; Robbie King (robking); Taras Kondratiuk Subject: [RFC 0/2] validation: crypto: remove code duplication Current crypto tests have a few issues: - Asynchronous tests assume that operation is always executed asynchronously, but specification does not demand it (I hope I read it correctly). So tests have to handle synchronous operations also. - If the first issue is solved, then Sync test is a subset of Async -> they can't be merged. The same approach should allow to easily add tests for 'out of place' operations. Taras Kondratiuk (2): validation: crypto: handle synchronous operations in async test validation: crypto: combine sync and async tests test/validation/Makefile.am | 3 +- ...ypto_test_async_inp.c => odp_crypto_test_inp.c} | 68 ++++-- ...ypto_test_async_inp.h => odp_crypto_test_inp.h} | 8 +- test/validation/crypto/odp_crypto_test_sync_inp.c | 271 --------------------- test/validation/crypto/odp_crypto_test_sync_inp.h | 17 -- test/validation/odp_crypto.c | 9 +- 6 files changed, 60 insertions(+), 316 deletions(-) rename test/validation/crypto/{odp_crypto_test_async_inp.c => odp_crypto_test_inp.c} (86%) rename test/validation/crypto/{odp_crypto_test_async_inp.h => odp_crypto_test_inp.h} (62%) delete mode 100644 test/validation/crypto/odp_crypto_test_sync_inp.c delete mode 100644 test/validation/crypto/odp_crypto_test_sync_inp.h -- 1.9.1 _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
