Maxim, Thanks for handling this for me and letting me know you aren't using Gerrit for ODP. If I have any more ODP patches I'll not send them to Gerrit!
Gary On Fri, Mar 6, 2015 at 7:59 AM, Maxim Uvarov <[email protected]> wrote: > Merged, > Maxim. > > On 03/06/15 16:41, Mike Holmes wrote: > >> >> >> On 6 March 2015 at 04:16, Maxim Uvarov <[email protected] <mailto: >> [email protected]>> wrote: >> >> fwd to odp mailing list. >> >> For odp now we do not use gerrit, we use mailing list. >> >> Maxim. >> >> >> -------- Forwarded Message -------- >> Subject: Change in lng/odp[master]: Replace deprecated >> _BSD_SOURCE with _DEFAULT_SOURCE >> Date: Fri, 06 Mar 2015 01:01:04 +0000 >> From: Gary Robertson (Code Review) <[email protected] >> <mailto:[email protected]>> >> Reply-To: [email protected] <mailto:[email protected] >> > >> To: Mike Holmes <[email protected] >> <mailto:[email protected]>>, Santosh Shukla >> <[email protected] <mailto:[email protected]>>, >> Maxim Uvarov <[email protected] >> <mailto:[email protected]>>, Anders Roxell >> <[email protected] <mailto:[email protected]>> >> >> >> >> Gary Robertson has uploaded a new change for review. >> >> https://review.linaro.org/4944 >> >> Change subject: Replace deprecated _BSD_SOURCE with _DEFAULT_SOURCE >> ............................................................ >> .......... >> >> Replace deprecated _BSD_SOURCE with _DEFAULT_SOURCE >> >> Compilation of ODP v1.0 on OpenEmbedded failed due to >> the following warning being treated as an error: >> | In file included from /usr/include/stdlib.h:24:0, >> | from odp/example/ipsec/odp_ipsec.c:16: >> | /usr/include/features.h:148:3: >> | error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, >> | use _DEFAULT_SOURCE" [-Werror=cpp] >> | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, >> | use _DEFAULT_SOURCE" >> | ^ >> >> Modified the source 'example/ipsec/odp_ipsec.c' as recommended. >> >> Change-Id: I3b8fb392611ea3ad35d17a9492637f44d7ca5d2c >> Signed-off-by: Gary S. Robertson <[email protected] >> <mailto:[email protected]>> >> >> >> Reviewed-and-tested-by: Mike Holmes <[email protected] <mailto: >> [email protected]>> >> Built for xcompile arm and x86 >> >> *_BSD_SOURCE*(deprecated since glibc 2.20) >> Defining this macro with any value causes header files to >> expose BSD-derived definitions. >> >> In glibc versions up to and including 2.18, defining this >> macro also causes BSD definitions to be preferred in some >> sit‐ >> uations where standards conflict, unless one or more of >> *_SVID_SOURCE*,*_POSIX_SOURCE*,*_POSIX_C_SOURCE*,*_XOPEN_ >> SOURCE*, >> *_XOPEN_SOURCE_EXTENDED*, or*_GNU_SOURCE*is defined, in >> which >> case BSD definitions are disfavored. Since glibc 2.19, >> *_BSD_SOURCE*no longer causes BSD definitions to be >> preferred >> in case of conflicts. >> >> Since glibc 2.20, this macro is deprecated. It now has the >> same effect as defining*_DEFAULT_SOURCE*, but generates a >> com‐ >> pile-time warning (unless*_DEFAULT_SOURCE*is also defined). >> Use*_DEFAULT_SOURCE*instead. To allow code that requires >> *_BSD_SOURCE*in glibc 2.19 and earlier >> and*_DEFAULT_SOURCE*in >> glibc 2.20 and later to compile without warnings, >> define/both/ >> *_BSD_SOURCE*and*_DEFAULT_SOURCE*. >> >> --- >> M example/ipsec/odp_ipsec.c >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> git pull ssh://review.linaro.org:29418/lng/odp >> <http://review.linaro.org:29418/lng/odp> refs/changes/44/4944/1 >> >> diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c >> index 70cd957..98160ba 100644 >> --- a/example/ipsec/odp_ipsec.c >> +++ b/example/ipsec/odp_ipsec.c >> @@ -10,7 +10,7 @@ >> * @example odp_example_ipsec.c ODP basic packet IO cross >> connect with IPsec test application >> */ >> -#define _BSD_SOURCE >> +#define _DEFAULT_SOURCE >> /* enable strtok */ >> #define _POSIX_C_SOURCE 200112L >> #include <stdlib.h> >> >> -- To view, visit https://review.linaro.org/4944 >> To unsubscribe, visit https://review.linaro.org/settings >> >> Gerrit-MessageType: newchange >> Gerrit-Change-Id: I3b8fb392611ea3ad35d17a9492637f44d7ca5d2c >> Gerrit-PatchSet: 1 >> Gerrit-Project: lng/odp >> Gerrit-Branch: master >> Gerrit-Owner: Gary Robertson <[email protected] >> <mailto:[email protected]>> >> >> >> >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] <mailto:[email protected]> >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> -- >> Mike Holmes >> Technical Manager - Linaro Networking Group >> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM >> SoCs >> >> > > _______________________________________________ > lng-odp mailing list > [email protected] > http://lists.linaro.org/mailman/listinfo/lng-odp >
_______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
