Reviewed-by: Petri Savolainen <[email protected]>
/** Packet pool*/ #define ODP_POOL_PACKET ODP_EVENT_PACKET /** Buffer pool */ #define ODP_POOL_BUFFER ODP_EVENT_BUFFER /** Timeout pool */ #define ODP_POOL_TIMEOUT ODP_EVENT_TIMEOUT In continuation, these define still linux-generic specific values and should be changed to spec only like this, /** * @def ODP_POOL_PACKET * Packet pool */ We may have similar definitions in other APIs also. Would you have time to check and send a patch for those. -Petri > -----Original Message----- > From: ext Taras Kondratiuk [mailto:[email protected]] > Sent: Friday, March 06, 2015 5:48 PM > To: Savolainen, Petri (Nokia - FI/Espoo); [email protected] > Cc: [email protected]; Taras Kondratiuk > Subject: [PATCH] api: pool: move platform includes to linux-generic > > Do not include platform-specific header files from common API headers. > > Signed-off-by: Taras Kondratiuk <[email protected]> > --- > include/odp/api/pool.h | 2 -- > platform/linux-generic/include/odp/pool.h | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h > index 6fe52fa..241b98a 100644 > --- a/include/odp/api/pool.h > +++ b/include/odp/api/pool.h > @@ -21,8 +21,6 @@ extern "C" { > > > #include <odp/std_types.h> > -#include <odp/plat/shared_memory_types.h> > -#include <odp/event.h> > > /** @addtogroup odp_buffer > * Operations on a pool. > diff --git a/platform/linux-generic/include/odp/pool.h b/platform/linux- > generic/include/odp/pool.h > index e68b11e..02bc3b7 100644 > --- a/platform/linux-generic/include/odp/pool.h > +++ b/platform/linux-generic/include/odp/pool.h > @@ -26,6 +26,8 @@ extern "C" { > */ > > #include <odp/plat/pool_types.h> > +#include <odp/plat/shared_memory_types.h> > +#include <odp/plat/event_types.h> > #include <odp/api/pool.h> > > #ifdef __cplusplus > -- > 1.9.1 _______________________________________________ lng-odp mailing list [email protected] http://lists.linaro.org/mailman/listinfo/lng-odp
