https://bugs.linaro.org/show_bug.cgi?id=1334

            Bug ID: 1334
           Summary: packet flag APIs are booleans and should follow
                    boolean guidelines
           Product: OpenDataPlane
           Version: 1.0
          Hardware: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: ---
         Component: Buffers & Packets
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]

The odp_packet_has_xxx() APIs are booleans and should be defined and tested as
such.  Per the ODP API Guidelines, boolean functions have return type
odp_bool_t that use false == 0 and true == !0.  

The test/validation/odp_packet.c program currently uses true == 1 and this
forces all implementations to conform to that stricter behavior even though the
guidelines say true == !0.  Either the guidelines need to be made more strict
or the test should be relaxed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to