I would like to reword that subject from:
validation: packet: use true == \!0 per ODP API Guidelines
to
"""
validation: check packet flags not not 0
odp packet flags functions return int while it's intend to be odp_bool_t.
odp_bool_t have to be checked for no 0.
"""
It should be better due to:
1. "== \!0" probably have to be "=! 0"
2. It's better not add symbols which you need escape with \. I.e. short
subject has to be easy search-able.
Maxim.
On 03/10/15 20:04, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org>
---
test/validation/odp_packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/odp_packet.c b/test/validation/odp_packet.c
index 8f764bf..0c1d069 100644
--- a/test/validation/odp_packet.c
+++ b/test/validation/odp_packet.c
@@ -425,7 +425,7 @@ do { \
odp_packet_has_##flag##_set(packet, 0); \
CU_ASSERT(odp_packet_has_##flag(packet) == 0); \
odp_packet_has_##flag##_set(packet, 1); \
- CU_ASSERT(odp_packet_has_##flag(packet) == 1); \
+ CU_ASSERT(odp_packet_has_##flag(packet) != 0); \
} while (0)
static void packet_in_flags(void)
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
