Re: [lng-odp] [PATCH 1/2] validation: timer: use ODP_SHM_NULL

Tue, 17 Mar 2015 04:32:08 -0700 

Merged,
Maxim.

On 03/06/15 20:30, Mike Holmes wrote:




On 6 March 2015 at 09:30, Petri Savolainen <[email protected] 
<mailto:[email protected]>> wrote:


    Use ODP_SHM_NULL to select default shm memory in odp_pool_create(),
    instead of ODP_SHM_INVALID.

    Signed-off-by: Petri Savolainen <[email protected]
    <mailto:[email protected]>>



Reviewed & Tested-by: Mike Holmes <[email protected] 
<mailto:[email protected]>>

arm & x86

Docs say
http://docs.opendataplane.org/odp/html/group__odp__buffer.html#ga4136c6b8dca5d6dfac533acfde5f4e1b

Parameters
    name        Name of the pool, max ODP_POOL_NAME_LEN-1 chars. May be
    specified as NULL for anonymous pools.
    shm         The shared memory object in which to create the pool. Use
    ODP_SHM_NULL to reserve default memory type for the pool type.
    params      Pool parameters.


    ---
     test/validation/odp_timer.c | 6 +++---
     1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/test/validation/odp_timer.c b/test/validation/odp_timer.c
    index 88af61b..2ef3b39 100644
    --- a/test/validation/odp_timer.c
    +++ b/test/validation/odp_timer.c
    @@ -64,7 +64,7 @@ static void test_timeout_pool_alloc(void)
                            .type  = ODP_POOL_TIMEOUT,
            };

    -       pool = odp_pool_create("timeout_pool_alloc",
    ODP_SHM_INVALID, &params);
    +       pool = odp_pool_create("timeout_pool_alloc", ODP_SHM_NULL,
    &params);
            odp_pool_print(pool);

            /* Try to allocate num items from the pool */
    @@ -104,7 +104,7 @@ static void test_timeout_pool_free(void)
                            .type  = ODP_POOL_TIMEOUT,
            };

    -       pool = odp_pool_create("timeout_pool_free",
    ODP_SHM_INVALID, &params);
    +       pool = odp_pool_create("timeout_pool_free", ODP_SHM_NULL,
    &params);
            odp_pool_print(pool);

            /* Allocate the only timeout from the pool */
    @@ -356,7 +356,7 @@ static void test_odp_timer_all(void)
            /* Create timeout pools */
            params.tmo.num = (NTIMERS + 1) * num_workers;
            params.type    = ODP_POOL_TIMEOUT;
    -       tbp = odp_pool_create("tmo_pool", ODP_SHM_INVALID, &params);
    +       tbp = odp_pool_create("tmo_pool", ODP_SHM_NULL, &params);
            if (tbp == ODP_POOL_INVALID)
                    CU_FAIL_FATAL("Timeout pool create failed");

    --
    2.3.1


    _______________________________________________
    lng-odp mailing list
    [email protected] <mailto:[email protected]>
    http://lists.linaro.org/mailman/listinfo/lng-odp




--
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs



_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp



_______________________________________________
lng-odp mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/lng-odp






















					Reply via email to