On 08/04/15 18:36, Mike Holmes wrote:
On 8 April 2015 at 13:02, Zoltan Kiss <[email protected]
<mailto:[email protected]>> wrote:
Hi,
OVS has a major performance issue with pktio at the moment: pktio
always does parsing, but OVS does it for itself as well, and it is
quite deeply woven into its code, so we can't easily modify it to
use the ODP parsed data. Also, not every platform accelerate that
(e.g. DPDK), at the moment it would make more sense to make parsing
optional for pktio, so an application can opt not to do it.
I can see two options now to define the API:
- odp_pktio_open get a new bool parameter for this purpose
- we create a new odp_pktio_enable/disable_parse function pair for
this purpose
Any opinions about these options?
I have another option
* How about an argument to global_init that can change the behavior -
unless this has to be per port in the same app and I think that is
less likely.
I can imagine a scenario when your app wants both: when you know you
have some traffic which is non-standard and therefore can't be properly
parsed by your hardware, but you also want to have a port with parsing on.
I think flexibility to be on a per-port basis doesn't hurt here.
That flag could even be an arg explicitly in the per platform flags
<http://docs.opendataplane.org/linux-generic-doxygen-html/structodp__platform__init__t.html>
for global_init and thus only for DPDK right now, this would allow
progress and document it is a platform hack.
Indeed, that would be a quicker solution, but not portable. I don't
think DPDK will be the only platform without good enough parsing.
OVS won't use parsing until we get a proper platform implementation
which supports that. Hopefully we get to upstreaming before that, but
that won't happen if we have platform specific code in ODP-OVS.
Regards,
Zoli
_________________________________________________
lng-odp mailing list
[email protected] <mailto:[email protected]>
https://lists.linaro.org/__mailman/listinfo/lng-odp
<https://lists.linaro.org/mailman/listinfo/lng-odp>
--
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs
__
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp
