On 14 April 2015 at 02:49, Christophe Milard <[email protected]> wrote:
> Well, helpers are quite confusing to me... > For instance, I don't see why the a checksum algorythm would be in helpers > while a crypto would be in ODP. both are condidate for HW acceleration. The > thread part should also belong to ODP. But some part make more sense, like > the definition of the ethertype. > At least, the separation you are trying to achieve will enlighten these > problems, so I am rather favorable to this patch. > But eventually, I an afraid we'll have to go through the whole helper API > and sort it out. > I am sure we will have to go though it. I think we got some clarity on today's call though. > > On 13 April 2015 at 20:45, Anders Roxell <[email protected]> wrote: > >> On 2015-04-07 10:12, Mike Holmes wrote: >> > The odph helper src files do not belong in linux-generic, move them out >> > to the helper directory. >> > From the helper directory they may be more cleanly extended to support >> > other execution environments beyond Linux. >> > Clean up checkpatch whitespace warning in the migrated code. >> > >> > Signed-off-by: Mike Holmes <[email protected]> >> >> Reviewed-by: Anders Roxell <[email protected]> >> >> > --- >> > >> > platform/linux-generic/odp_linux.c => helper/src/linux.c | 1 - >> > platform/linux-generic/odp_ring.c => helper/src/ring.c | 0 >> > platform/linux-generic/Makefile.am | 4 ++-- >> > 3 files changed, 2 insertions(+), 3 deletions(-) >> > rename platform/linux-generic/odp_linux.c => helper/src/linux.c (99%) >> > rename platform/linux-generic/odp_ring.c => helper/src/ring.c (100%) >> > >> > diff --git a/platform/linux-generic/odp_linux.c b/helper/src/linux.c >> > similarity index 99% >> > rename from platform/linux-generic/odp_linux.c >> > rename to helper/src/linux.c >> > index 6865ab1..b753e4d 100644 >> > --- a/platform/linux-generic/odp_linux.c >> > +++ b/helper/src/linux.c >> > @@ -141,7 +141,6 @@ void odph_linux_pthread_join(odph_linux_pthread_t >> *thread_tbl, int num) >> > pthread_attr_destroy(&thread_tbl[i].attr); >> > free(thread_tbl[i].start_args); >> > } >> > - >> > } >> > >> > >> > diff --git a/platform/linux-generic/odp_ring.c b/helper/src/ring.c >> > similarity index 100% >> > rename from platform/linux-generic/odp_ring.c >> > rename to helper/src/ring.c >> > diff --git a/platform/linux-generic/Makefile.am >> b/platform/linux-generic/Makefile.am >> > index e5558ac..aa8973b 100644 >> > --- a/platform/linux-generic/Makefile.am >> > +++ b/platform/linux-generic/Makefile.am >> > @@ -149,14 +149,14 @@ __LIB__libodp_la_SOURCES = \ >> > odp_event.c \ >> > odp_init.c \ >> > odp_impl.c \ >> > - odp_linux.c \ >> > + ../../helper/src/linux.c \ >> > odp_packet.c \ >> > odp_packet_flags.c \ >> > odp_packet_io.c \ >> > odp_packet_socket.c \ >> > odp_pool.c \ >> > odp_queue.c \ >> > - odp_ring.c \ >> > + ../../helper/src/ring.c \ >> > odp_rwlock.c \ >> > odp_schedule.c \ >> > odp_shared_memory.c \ >> > -- >> > 2.1.0 >> > >> > _______________________________________________ >> > lng-odp mailing list >> > [email protected] >> > https://lists.linaro.org/mailman/listinfo/lng-odp >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
