On 22 April 2015 at 06:55, Taras Kondratiuk <[email protected]>
wrote:

> On 04/22/2015 12:39 AM, Mike Holmes wrote:
>
>> Code rules IMHO - the compiler will ensure we follow the rules.
>>
>> Can we add test cases to prove the behavior across all platforms,
>> linux-generic being one of them, and thus the code is correct no matter
>> what is written anywhere else. Presumably the api documentation matches
>> the code but it should be updated and clarified to match the behavior
>> proven by the test cases.
>>
>
> We can't check ambiguous rules by compiler or tests.
> IMO better to copy part of design document into classification.h to
> clarify the behavior.


That works for me as long as we do specify the behavior - should some
element of that documentation improvement be attached to this patch since
it spawned the discussion ?


>
>
>
>> I do not think referencing the classification design document has any
>> value any more it is no longer a maintained document, however I
>> do recall as Bill says that we decided it was the applications
>> responsibility be unambiguous.
>>
>
> I agree it should be application responsibility. Implementation may assist
> here and throw an error in case it detects an ambiguous combination.
>



-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to