I sent out v2 with extra line feeds between the struct members. I think it’s 
very well readable now.

The series touch the same lines in pool.h. Those patches apply easier 
back-to-back, than mixed with (potential) other patches.

-Petri


From: ext Bill Fischofer [mailto:[email protected]]
Sent: Thursday, April 23, 2015 4:03 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH 3/4] style: pool_param doxygen comments

I disagree that this style is more readable.  It's hard to see the definitions 
when they are stacked like this.  Having the comments on the right makes it 
very clear what they are associated with and doesn't obscure the variables.  
This sort of stylistic change really has nothing to do with the overall intent 
of this patch series, which is just to rename user_data to user_area.

On Thu, Apr 23, 2015 at 7:23 AM, Petri Savolainen 
<[email protected]<mailto:[email protected]>> wrote:
Moved comments into separate lines for better readability (more
chars per line).



_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to