On 28 April 2015 at 08:55, Stuart Haslam <[email protected]> wrote:
> On Tue, Apr 28, 2015 at 12:49:48PM +0300, Maxim Uvarov wrote: > > On 04/27/2015 22:22, Anders Roxell wrote: > > >On 2015-04-21 16:26, Mike Holmes wrote: > > >>The helpers need to be tested independently from the ODP API, create a > > >>folder to contain helper tests, adding tests for process and thread > > >>creation. > > >> > > >>Signed-off-by: Mike Holmes <[email protected]> > > >>--- > > >> configure.ac | 15 +++++++++ > > >> test/Makefile.am | 5 ++- > > >> test/helper/.gitignore | 4 +++ > > >> test/helper/Makefile.am | 25 ++++++++++++++ > > >> test/helper/odp_process.c | 85 > +++++++++++++++++++++++++++++++++++++++++++++++ > > >> test/helper/odp_thread.c | 79 > +++++++++++++++++++++++++++++++++++++++++++ > > >I think we should put helper tests in helper/test. > > >It will be easier to rip helper out to its own repo in the future. > > > > > >Cheers, > > >Anders > > No, tests should be in some common place. We had a lot of > > discussions for that before. > > No need to rip out to own repo helpers. > > > > Thanks, > > Maxim. > > > > I also think that helper/test is a better location for these tests as it > maintains a clearer separation of the helpers from the ODP API, which is > good given it's already a bit confusing. So we'd have; > > test/ -> ODP API tests > helper/test/ -> helper tests > > And maybe later.. > > platform/<platform>/test/ -> platform specific tests > We need this already to test things like replacing the abort function with global init, it needs to provoke the call to the function to prove it works and that is only possible with internal knowledge. > > -- > Stuart. > _______________________________________________ > lng-odp mailing list > [email protected] > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
