Merged,
Maxim.

On 05/07/2015 16:50, Bill Fischofer wrote:


On Wed, May 6, 2015 at 3:04 AM, Nicolas Morey-Chaisemartin <[email protected] <mailto:[email protected]>> wrote:

    Signed-off-by: Nicolas Morey-Chaisemartin <[email protected]
    <mailto:[email protected]>>


Reviewed-by: Bill Fischofer <[email protected] <mailto:[email protected]>>

    ---

    Submitted this patch a couple of weeks ago with a bad title (
    [PATCHv2] Use inttypes defines to print (u)int32_t values) and
    didn't any feedback.

     platform/linux-generic/odp_buffer.c |  4 ++--
     platform/linux-generic/odp_packet.c | 14 +++++++-------
     2 files changed, 9 insertions(+), 9 deletions(-)

    diff --git a/platform/linux-generic/odp_buffer.c
    b/platform/linux-generic/odp_buffer.c
    index a9d0e24..0803805 100644
    --- a/platform/linux-generic/odp_buffer.c
    +++ b/platform/linux-generic/odp_buffer.c
    @@ -81,9 +81,9 @@ int odp_buffer_snprint(char *str, uint32_t n,
    odp_buffer_t buf)
            len += snprintf(&str[len], n-len,
                            "  addr         %p\n", hdr->addr);
            len += snprintf(&str[len], n-len,
    -                       "  size         %u\n", hdr->size);
+ " size %" PRIu32 "\n", hdr->size);
            len += snprintf(&str[len], n-len,
    -                       "  ref_count    %i\n",
    +                       "  ref_count    %" PRIu32 "\n",
    odp_atomic_load_u32(&hdr->ref_count));
            len += snprintf(&str[len], n-len,
                            "  type         %i\n", hdr->type);
    diff --git a/platform/linux-generic/odp_packet.c
    b/platform/linux-generic/odp_packet.c
    index c5a3f7d..815c57f 100644
    --- a/platform/linux-generic/odp_packet.c
    +++ b/platform/linux-generic/odp_packet.c
    @@ -558,19 +558,19 @@ void odp_packet_print(odp_packet_t pkt)
            len += snprintf(&str[len], n-len, "Packet ");
            len += odp_buffer_snprint(&str[len], n-len, (odp_buffer_t)
    pkt);
            len += snprintf(&str[len], n-len,
    -                       "  input_flags  0x%x\n",
    hdr->input_flags.all);
    +                       "  input_flags  0x%" PRIx32 "\n",
    hdr->input_flags.all);
            len += snprintf(&str[len], n-len,
    -                       "  error_flags  0x%x\n",
    hdr->error_flags.all);
    +                       "  error_flags  0x%" PRIx32 "\n",
    hdr->error_flags.all);
            len += snprintf(&str[len], n-len,
    -                       "  output_flags 0x%x\n",
    hdr->output_flags.all);
    +                       "  output_flags 0x%" PRIx32 "\n",
    hdr->output_flags.all);
            len += snprintf(&str[len], n-len,
    -                       "  l2_offset    %u\n", hdr->l2_offset);
    +                       "  l2_offset    %" PRIu32 "\n",
    hdr->l2_offset);
            len += snprintf(&str[len], n-len,
    -                       "  l3_offset    %u\n", hdr->l3_offset);
    +                       "  l3_offset    %" PRIu32 "\n",
    hdr->l3_offset);
            len += snprintf(&str[len], n-len,
    -                       "  l4_offset    %u\n", hdr->l4_offset);
    +                       "  l4_offset    %" PRIu32 "\n",
    hdr->l4_offset);
            len += snprintf(&str[len], n-len,
    -                       "  frame_len    %u\n", hdr->frame_len);
    +                       "  frame_len    %" PRIu32 "\n",
    hdr->frame_len);
            len += snprintf(&str[len], n-len,
                            "  input        %" PRIu64 "\n",
                            odp_pktio_to_u64(hdr->input));
    _______________________________________________
    lng-odp mailing list
    [email protected] <mailto:[email protected]>
    https://lists.linaro.org/mailman/listinfo/lng-odp




_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to