On 28/05/15 15:32, Ola Liljedahl wrote:
On 28 May 2015 at 16:25, Zoltan Kiss <[email protected]
<mailto:[email protected]>> wrote:
Yes, I missed that prefix. Do you want me to resend the patch?
I'll send an another patch to implement this behaviour in the repo
wherever odp_pktio_send is called. But I think we can't create a
unit test for it, can we?
We can sort-of test that any packets not being consumed by
odp_pktio_send() still are ours and valid (although I think it is
implementation specific whether ODP will detect any violations, e.g.
whether it detects that an application uses a packet handle it does not
"own").
But can we force odp_pktio_send() not to consume all packets passed to
it? This seems less likely.
Yes, that's why I'm concerned if we can test that out somehow.
Zoli
On 28/05/15 14:56, Bill Fischofer wrote:
This needs to be API-NEXT as it is a change to an API file.
On Thu, May 28, 2015 at 7:53 AM, Savolainen, Petri (Nokia -
FI/Espoo)
<[email protected] <mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>> wrote:
Reviewed-by: Petri Savolainen <[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>
> -----Original Message-----
> From: lng-odp [mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>] On Behalf Of ext
> Zoltan Kiss
> Sent: Thursday, May 28, 2015 3:19 PM
> To: [email protected]
<mailto:[email protected]>
<mailto:[email protected] <mailto:[email protected]>>
> Subject: [lng-odp] [PATCH] api-next: packet_io: clarify what
happens when
> not all packets are sent
>
> Currently our examples are not handling this situation
as well.
>
> Signed-off-by: Zoltan Kiss <[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>
> ---
> include/odp/api/packet_io.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/odp/api/packet_io.h
b/include/odp/api/packet_io.h
> index 89356a6..b97b2b8 100644
> --- a/include/odp/api/packet_io.h
> +++ b/include/odp/api/packet_io.h
> @@ -111,7 +111,9 @@ int odp_pktio_recv(odp_pktio_t pktio,
odp_packet_t
> pkt_table[], int len);
> * @param pkt_table[] Array of packets to send
> * @param len length of pkt_table[]
> *
> - * @return Number of packets sent
> + * @return Number of packets sent. If it is less than
'len', the
> remaining
> + * packets at the end of pkt_table[] are left intact,
and caller
has to
> take
> + * care of them.
> * @retval <0 on failure
> */
> int odp_pktio_send(odp_pktio_t pktio, odp_packet_t
pkt_table[],
int len);
> --
> 1.9.1
>
> _______________________________________________
> lng-odp mailing list
> [email protected]
<mailto:[email protected]>
<mailto:[email protected] <mailto:[email protected]>>
> https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
[email protected] <mailto:[email protected]>
<mailto:[email protected] <mailto:[email protected]>>
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
[email protected] <mailto:[email protected]>
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp
