On Wed, Jun 17, 2015 at 2:51 PM, Mike Holmes <[email protected]> wrote:

> The assert macro also assigns a variable.
> Potentially modifying (disabling) the macro would also change the
> operation of the test.
>
> Fixes CID 96200
>
> Signed-off-by: Mike Holmes <[email protected]>
>

Reviewed-by: Bill Fischofer <[email protected]>


> ---
>  test/validation/pktio/pktio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
> index 8cfa269..93d68f2 100644
> --- a/test/validation/pktio/pktio.c
> +++ b/test/validation/pktio/pktio.c
> @@ -541,7 +541,8 @@ static void pktio_test_inq_remdef(void)
>
>         CU_ASSERT(pktio != ODP_PKTIO_INVALID);
>         CU_ASSERT(create_inq(pktio, ODP_QUEUE_TYPE_POLL) == 0);
> -       CU_ASSERT((inq = odp_pktio_inq_getdef(pktio)) !=
> ODP_QUEUE_INVALID);
> +       inq = odp_pktio_inq_getdef(pktio);
> +       CU_ASSERT(inq != ODP_QUEUE_INVALID);
>         CU_ASSERT(odp_pktio_inq_remdef(pktio) == 0);
>
>         for (i = 0; i < 100; i++) {
> --
> 2.1.4
>
> _______________________________________________
> lng-odp mailing list
> [email protected]
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to