You don t need to add the lng-odp part. The mailing list doed it on its own when it s not in the title already
Envoyé depuis un mobile Samsung. <div>-------- Message d'origine --------</div><div>De : Ivan Khoronzhuk <[email protected]> </div><div>Date :15/07/2015 18:34 (GMT+01:00) </div><div>À : Bill Fischofer <[email protected]>, Genis Riera <[email protected]> </div><div>Cc : ODP mailing list <[email protected]> </div><div>Objet : Re: [lng-odp] [PATCH] api: pool: add headroom init parameter to odp_pool_param_t </div><div> </div> On 15.07.15 19:20, Bill Fischofer wrote: > Any proposed API changes need to be tagged API-NEXT. Proper patch > procedure is the following: > > git clone http://git.linaro.org/lng/odp.git myodp > cd myodp > git checkout -b api-next origin/api-next > ...Make your changes and commits locally > git format-patch origin/api-next --subject-prefix="API-NEXT PATCH" --subject-prefix=lng-odp]\ [API-NEXT PATCH Correct me if I'm wrong > // Make sure your patches are checkpatch clean: > ./scripts/checkpatch *.patch > git send-email [email protected] > <mailto:[email protected]> *.patch > You can simplify by adding hook to: .git/hooks/post-commit git show --format=email | ./scripts/checkpatch.pl --strict --mailback --show-types - Just to see issues when adding a commit. > > > On Wed, Jul 15, 2015 at 11:11 AM, Genis Riera > <[email protected] <mailto:[email protected]>> wrote: > > Ivan, > > If you have this compilation issues I can send again the patch > without this check, assuming always positive values. Is it right for > you? > > Genís Riera Pérez > Software Engineer at StarFlow Networks > Edifici K2M, S103 c/ Jordi Girona 31 > 08034 Barcelona > > E-mail: [email protected] <mailto:[email protected]> > > On Wed, Jul 15, 2015 at 6:04 PM, Ivan Khoronzhuk > <[email protected] <mailto:[email protected]>> wrote: > > Genis > > On 15.07.15 19:00, Genis Riera wrote: > > Hi, Ivan, > > Not, but I added this check just in case of error when > defines this > parameter (e.g., when misstyping). > > > Usually I have compilation error/warn when trying to compare > unsigned int on value < 0. > > > Best, > > Genís Riera Pérez > Software Engineer at StarFlow Networks > Edifici K2M, S103 c/ Jordi Girona 31 > 08034 Barcelona > > E-mail: [email protected] > <mailto:[email protected]> > <mailto:[email protected] > <mailto:[email protected]>> > > On Wed, Jul 15, 2015 at 5:54 PM, Ivan Khoronzhuk > <[email protected] > <mailto:[email protected]> > <mailto:[email protected] > <mailto:[email protected]>>> wrote: > > Hi, Genis > > On 15.07.15 18:47, Genis Riera wrote: > > A new headroom parameter is added to > odp_pool_param_t when the > pool is > type of ODP_POOL_PACKET, so that headroom size could be > configured at > pool initialization time (ODP application runtime). > > Signed-off-by: Genis Riera Perez > <[email protected] > <mailto:[email protected]> > <mailto:[email protected] > <mailto:[email protected]>> > <mailto:[email protected] > <mailto:[email protected]> > > <mailto:[email protected] > <mailto:[email protected]>>>> > > -- > include/odp/api/pool.h | 5 +++++ > platform/linux-generic/odp_pool.c | 10 +++++++++- > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/include/odp/api/pool.h > b/include/odp/api/pool.h > index e5061ab..913f510 100644 > --- a/include/odp/api/pool.h > +++ b/include/odp/api/pool.h > @@ -82,6 +82,11 @@ typedef struct odp_pool_param_t { > /** User area size in > bytes. Specify > as 0 if no > user > area is needed. */ > uint32_t uarea_size; > + > + /** Packet headroom size in > bytes. The > maximum > and the > + default value is defined by > ODP_CONFIG_PACKET_HEADROOM. > + Use 0 for default. */ > + uint32_t headroom; > } pkt; > struct { > /** Number of timeouts in > the pool */ > diff --git a/platform/linux-generic/odp_pool.c > b/platform/linux-generic/odp_pool.c > index dcbdf07..9359e53 100644 > --- a/platform/linux-generic/odp_pool.c > +++ b/platform/linux-generic/odp_pool.c > @@ -201,7 +201,15 @@ odp_pool_t > odp_pool_create(const char *name, > case ODP_POOL_PACKET: > unseg = 0; /* Packets are always > segmented */ > - headroom = ODP_CONFIG_PACKET_HEADROOM; > + > + /* If headroom is not specified by > params, > + set it to the default */ > + if (params->pkt.headroom <= 0 || > + params->pkt.headroom > > ODP_CONFIG_PACKET_HEADROOM) > > > Can headroom be < 0? > > + headroom = > ODP_CONFIG_PACKET_HEADROOM; > + else > + headroom = > params->pkt.headroom; > + > tailroom = > ODP_CONFIG_PACKET_TAILROOM; > buf_num = params->pkt.num; > > > Genís Riera Pérez > Software Engineer at StarFlow Networks > Edifici K2M, S103 c/ Jordi Girona 31 > 08034 Barcelona > > E-mail: [email protected] > <mailto:[email protected]> > <mailto:[email protected] > <mailto:[email protected]>> > <mailto:[email protected] > <mailto:[email protected]> > <mailto:[email protected] > <mailto:[email protected]>>> > > > _______________________________________________ > lng-odp mailing list > [email protected] <mailto:[email protected]> > <mailto:[email protected] > <mailto:[email protected]>> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > _______________________________________________ > lng-odp mailing list > [email protected] <mailto:[email protected]> > https://lists.linaro.org/mailman/listinfo/lng-odp > > _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
