On 07/17/15 14:42, Bill Fischofer wrote:
Nicolas opened this bug and assigned it to me and I see we cross-posted fix patches. My patch is at http://patches.opendataplane.org/patch/2298/ and is almost the same (I'm using <= rather than < which is slightly more efficient for the boundary case where seg_len == ODP_CONFIG_PACKET_SEG_LEN_MIN.
I think it's better to have the same check in 2 case. Or <= or <. Btw. why <= is more efficient? Compiler better optimizes that? Thank you, Maxim.
On Fri, Jul 17, 2015 at 6:04 AM, Stuart Haslam <[email protected] <mailto:[email protected]>> wrote:On Fri, Jul 17, 2015 at 12:45:52PM +0200, Nicolas Morey-Chaisemartin wrote: > Fixes https://bugs.linaro.org/show_bug.cgi?id=1696 > > Signed-off-by: Nicolas Morey-Chaisemartin <[email protected] <mailto:[email protected]>> Reviewed-by: Stuart Haslam <[email protected] <mailto:[email protected]>> > --- > platform/linux-generic/odp_pool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c > index dcbdf07..0f84eb5 100644 > --- a/platform/linux-generic/odp_pool.c > +++ b/platform/linux-generic/odp_pool.c > @@ -205,7 +205,7 @@ odp_pool_t odp_pool_create(const char *name, > tailroom = ODP_CONFIG_PACKET_TAILROOM; > buf_num = params->pkt.num; > > - seg_len = params->pkt.seg_len == 0 ? > + seg_len = params->pkt.seg_len < ODP_CONFIG_PACKET_SEG_LEN_MIN ? > ODP_CONFIG_PACKET_SEG_LEN_MIN : > (params->pkt.seg_len <= ODP_CONFIG_PACKET_SEG_LEN_MAX ? > params->pkt.seg_len : ODP_CONFIG_PACKET_SEG_LEN_MAX); > -- > 2.4.5.3.g4915f6f > > _______________________________________________ > lng-odp mailing list > [email protected] <mailto:[email protected]> > https://lists.linaro.org/mailman/listinfo/lng-odp -- Stuart. _______________________________________________ lng-odp mailing list [email protected] <mailto:[email protected]> https://lists.linaro.org/mailman/listinfo/lng-odp _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
