https://bugs.linaro.org/show_bug.cgi?id=1701

            Bug ID: 1701
           Summary: validation/packet assumes the number of available
                    segments
           Product: OpenDataPlane
           Version: 1.1
          Hardware: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Buffers & Packets
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]

Created attachment 353
  --> https://bugs.linaro.org/attachment.cgi?id=353&action=edit
Patch to reproduce bug

packet validation tests assumes that there can be at least 5 segments in a
packet to force segmentation:

static const uint32_t segmented_packet_len = PACKET_BUF_LEN * 5 -
    ODP_CONFIG_PACKET_HEADROOM - ODP_CONFIG_PACKET_TAILROOM -
    PACKET_TAILROOM_RESERVE;

Error an be reproduced by changing ODP_CONFIG_PACKET_BUF_LEN so there is no
possible segmentation (see patch attached).

packet test then fails with:
WARNING - Suite initialization failed for 'packet tests'.

Run Summary:    Type  Total    Ran Passed Failed Inactive
              suites      1      0    n/a      1        0
               tests     18      0      0      0        0
             asserts      0      0      0      0      n/a

Elapsed time =    0.000 seconds

Aborting due to error #22: Suite initialization function failed.


My best guess to fix this would be to make the max segmentation part of the
config API.


Bug was introduced by this commit
Author:     Bill Fischofer <[email protected]>
AuthorDate: Thu Jun 25 16:48:12 2015 -0500
Commit:     Maxim Uvarov <[email protected]>
CommitDate: Wed Jul 1 14:45:22 2015 +0300

    validation: packet: add segmented packet segment tests

    Extend segment tests to catch Bug
https://bugs.linaro.org/show_bug.cgi?id=1661

    Signed-off-by: Bill Fischofer <[email protected]>
    Review-and-tested-by: Nicolas Morey-Chaisemartin <[email protected]>
    Signed-off-by: Maxim Uvarov <[email protected]>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to