On 07/22/15 15:02, Nicolas Morey-Chaisemartin wrote:
On 07/22/2015 01:23 PM, Maxim Uvarov wrote:
On 07/22/15 13:57, Nicolas Morey-Chaisemartin wrote:
On 07/22/2015 12:00 PM, Maxim Uvarov wrote:
On 07/17/15 12:15, Nicolas Morey-Chaisemartin wrote:
.open = sock_mmsg_open,
- .close = sock_close_pkt,
+ .close = sock_close,
.recv = sock_mmsg_recv_pkt,
.send = sock_mmsg_send_pkt,
Nicolas, I'm going to apply first patch. But in that patch it's not clear why
you also did not remove _pkt from recv and send functions.
Because all the interfaces used the exact same name so I wasn't sure it was
worth it.
If we want to have a standar <pktio>_<action> name for all methods, I might aswell rename
the <pktio>_mac_addr_get to <pktio>_mac_get too
Nicolas
All this functions are static. And having prefix on some of them and do not
have on others is strange.
For mac addr, I think, you should not drop addr word to better match with api
call odp_pktio_mac_addr()
Maxim.
Maybe drop the get so we have <pktio type>_mac_addr() then ?
There might be set mac addr. But we decided to not include it to
odp1.x. I think get is ok also.
Maxim.
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
