Ivan, Which kind of built error? In fact, when validation codes are enabled, there was already an build error exist in the test/validation/crypto code, this error isn't introduced by my patches, if you compile validation without my patches, you'll see this error again. I didn't spend time to research why, just simply disable the crypto codes in Mikefile. Another error may be default compiling treat warnings as errors, so I use this command to config: ./configure --enable-test-vald CFLAGS="-O0 -g -Wno-error"
Are these the errors you met? On 15 September 2015 at 22:30, Mike Holmes <[email protected]> wrote: > > > On 15 September 2015 at 10:18, Ivan Khoronzhuk <[email protected]> > wrote: >> >> Hi, Hongbo >> >> Can it be built after this change? Should it be build-able at least? > > > All series should be build-able - if the check-odp apply-and-build script > does not pass it cannot be committed. > >> >> >> >> On 15.09.15 16:55, [email protected] wrote: >>> >>> From: Hongbo Zhang <[email protected]> >>> >>> This patch moves odp_sys_cpu_model_str() to cpu.h, all the calling >>> functions will be updated in later separate patch. >>> >>> Signed-off-by: Hongbo Zhang <[email protected]> >>> --- >>> include/odp/api/cpu.h | 9 +++++++++ >>> include/odp/api/system_info.h | 7 ------- >>> platform/linux-generic/odp_system_info.c | 2 +- >>> 3 files changed, 10 insertions(+), 8 deletions(-) >>> >>> diff --git a/include/odp/api/cpu.h b/include/odp/api/cpu.h >>> index c389093..78c3ffc 100644 >>> --- a/include/odp/api/cpu.h >>> +++ b/include/odp/api/cpu.h >>> @@ -44,6 +44,15 @@ int odp_cpu_id(void); >>> int odp_cpu_count(void); >>> >>> /** >>> + * CPU model name of this CPU >>> + * >>> + * Returns the CPU model name of this CPU. >>> + * >>> + * @return Pointer to CPU model name string >>> + */ >>> +const char *odp_cpu_model_str(void); >>> + >>> +/** >>> * @} >>> */ >>> >>> diff --git a/include/odp/api/system_info.h >>> b/include/odp/api/system_info.h >>> index e55ff6d..1cd883f 100644 >>> --- a/include/odp/api/system_info.h >>> +++ b/include/odp/api/system_info.h >>> @@ -45,13 +45,6 @@ uint64_t odp_sys_huge_page_size(void); >>> uint64_t odp_sys_page_size(void); >>> >>> /** >>> - * CPU model name >>> - * >>> - * @return Pointer to CPU model name string >>> - */ >>> -const char *odp_sys_cpu_model_str(void); >>> - >>> -/** >>> * Cache line size in bytes >>> * >>> * @return CPU cache line size in bytes >>> diff --git a/platform/linux-generic/odp_system_info.c >>> b/platform/linux-generic/odp_system_info.c >>> index 83226f8..ed6b515 100644 >>> --- a/platform/linux-generic/odp_system_info.c >>> +++ b/platform/linux-generic/odp_system_info.c >>> @@ -389,7 +389,7 @@ uint64_t odp_sys_page_size(void) >>> return odp_global_data.system_info.page_size; >>> } >>> >>> -const char *odp_sys_cpu_model_str(void) >>> +const char *odp_cpu_model_str(void) >>> { >>> return odp_global_data.system_info.model_str[0]; >>> } >>> >> >> -- >> Regards, >> Ivan Khoronzhuk > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org │ Open source software for ARM SoCs > > _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
