The issue come from git_hash it self. Not the Makefile. I'm sending a patch right now.
On 10/15/2015 05:28 PM, Ivan Khoronzhuk wrote: > I build it at api-next and see this: > ... > fatal: No names found, cannot describe anything. > CC odp_system_info.lo > fatal: No names found, cannot describe anything. > CC odp_thread.lo > fatal: No names found, cannot describe anything. > CC odp_thrmask.lo > CC odp_ticketlock.lo > CC odp_timer.lo > CC odp_time.lo > fatal: No names found, cannot describe anything. > fatal: No names found, cannot describe anything. > fatal: No names found, cannot describe anything. > fatal: No names found, cannot describe anything. > CC odp_version.lo > fatal: No names found, cannot describe anything. > CC odp_weak.lo > fatal: No names found, cannot describe anything. > CC pktio/io_ops.lo > CC pktio/loop.lo > fatal: No names found, cannot describe anything. > fatal: No names found, cannot describe anything. > CC pktio/netmap.lo > fatal: No names found, cannot describe anything. > CC pktio/socket.lo > fatal: No names found, cannot describe anything. > CC pktio/socket_mmap.lo > fatal: No names found, cannot describe anything. > CC arch/x86/odp_cpu_cycles.lo > fatal: No names found, cannot describe anything. > ... > > I had a talk with Maxim at connect and he was surprised. > We tried several methods with modifing dirs. > When I've used $() instead of `` it helped but broke smth else... > > > On 15.10.15 18:20, Nicolas Morey-Chaisemartin wrote: >> Maybe changing the directory before running git_hash.sh would fix your issue >> and keep the old make working ? >> >> Something like >> >> This was fixed some time ago: >> >> commit 06537738ea438c3e339fc269dedb4ed6c5e48f07 >> Author: Anders Roxell <[email protected]> >> Date: Fri Aug 14 15:25:05 2015 +0200 >> >> scripts/git_hash: fix build from tar source >> >> Signed-off-by: Anders Roxell <[email protected]> >> Reviewed-and-tested-by: Mike Holmes <[email protected]> >> Signed-off-by: Maxim Uvarov <[email protected]> >> >> Call to git_hash now adds a path to top_srcdir and handles non git dir >> >> On 10/15/2015 05:10 PM, Ivan Khoronzhuk wrote: >>> This reverts commit a9cc0fc700a4a8b9589404a18136b01974ca4aa3. >>> >>> This revert helps me to revert messages like: >>> "fatal: No names found, cannot describe anything." in case if I build >>> ODP outside of source catalog by: >>> >>> ../../odp/configure --enable-test-perf --enable-test-vald >>> make >>> >>> Seems it's connected with nesting `...`. >>> >>> Is someone going to fix it? >>> >>> --- >>> >>> platform/Makefile.inc | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/platform/Makefile.inc b/platform/Makefile.inc >>> index f64e37c..f232daa 100644 >>> --- a/platform/Makefile.inc >>> +++ b/platform/Makefile.inc >>> @@ -12,6 +12,6 @@ lib_LTLIBRARIES = $(LIB)/libodp.la >>> >>> AM_LDFLAGS += -version-number '$(ODP_LIBSO_VERSION)' >>> >>> -GIT_DESC = `$(top_srcdir)/scripts/git_hash.sh` >>> +GIT_DESC !=$(top_srcdir)/scripts/git_hash.sh >>> AM_CFLAGS += "-DGIT_HASH=$(GIT_DESC)" >>> AM_CFLAGS += -DPLATFORM=${with_platform} >> > _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
