> -----Original Message----- > From: EXT Ivan Khoronzhuk [mailto:[email protected]] > Sent: Friday, October 23, 2015 2:12 PM > To: Savolainen, Petri (Nokia - FI/Espoo); EXT Maxim Uvarov; lng- > [email protected] > Subject: Re: [lng-odp] [PATCHv5 2/2] api: pktio statistics: define start > and stop > > > > On 23.10.15 14:03, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > User tells to the implementation on open() which interfaces needed > statistics. > > As long as implementation has enough stat resources open() succeeds. > > When all stats are gone and user still ask for stats, open() fails. > >Implementation user manual documents this limitation (how many interfaces > can be > > opened with stats enabled and in which combination). > > > > -Petri > > Is it absolutely required for pktio to have statistic? > If no, then I can disable statistic for pktio after some test and use it > for another port. > And closing pktio is not needed....
It's not very useful to gather statistics part time. Either you need stats from an interface and want to count all packets (define ODP_PKTIO_STATS_BASIC), or you don’t need those at all (define ODP_PKTIO_STATS_DISABLED). What is the use case to time slice stats counting between two interfaces and potentially see zero packets on both, while packets are actually send and received (while you are measuring the other interface). -Petri > > >> -----Original Message----- > >> From: EXT Ivan Khoronzhuk [mailto:[email protected]] > >> Sent: Friday, October 23, 2015 2:00 PM > >> To: Savolainen, Petri (Nokia - FI/Espoo); EXT Maxim Uvarov; lng- > >> [email protected] > >> Subject: Re: [lng-odp] [PATCHv5 2/2] api: pktio statistics: define start > >> and stop > >> > >> > >> > >> On 23.10.15 13:35, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >>> > >>> I think these are not generally needed or supported. It's better to add > a > >> parameter into odp_pktio_param_t. > >> > >> It's needed. > >> The main reason for that the same statistic module can be used by > different > >> pktios, so if it's used for one of them it cannot be used by other, to > >> allow > >> it for first it should be disable for second. For instance 2 statistic > >> modules > >> are shared between 4 eth ports, etc. > >> > >>> > >>> For example, > >>> > >>> typedef enum odp_pktio_stats_mode_t { > >>> > >>> /** Need basic statistics on this interface */ > >>> ODP_PKTIO_STATS_BASIC = 0, > >>> /** Don't need any statistics on this interface */ > >>> ODP_PKTIO_STATS_DISABLED > >>> } odp_pktio_stats_mode_t; > >>> > >>> > >>> -Petri > >>> > >>> _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
