prefix odp_ should not be set for internal functions:

./platform/linux-generic/odp_traffic_mngr.c: sorted_list = odp_sorted_list_create( ./platform/linux-generic/odp_sorted_list.c:odp_int_sorted_list_t odp_sorted_list_create(odp_int_sorted_pool_t sorted_pool,
Binary file ./platform/linux-generic/odp_traffic_mngr.o matches
./platform/linux-generic/include/odp_sorted_list_internal.h:odp_int_sorted_list_t odp_sorted_list_create(odp_int_sorted_pool_t sorted_pool,

btw, do we need odp API for sorted list? Why not move it to include/ ?

Same comment for:
+odp_timer_wheel_t odp_timer_wheel_create(uint32_t max_concurrent_timers,
+                                        uint64_t current_time);

and other odp_timer_wheel_  functions.

Thank you,
Maxim.


On 10/22/2015 23:43, Bill Fischofer wrote:
Changes in v6
- Move documentation of packet colors to main API file
- Add ODP prefix to odp_tm_egress_kind_t enums

Changes in v5
- Add include file odp_traffic_mngr_internal.h
- Add support for odp_tm_enq() from packets originating from ordered queues

Changes in v4
- Incorporate API changes suggested by Petri

Changes in v3
- Fix checkpatch errors (Bill)

Changes in v2
- Full patch submission (Barry)

Barry Spinney (4):
   api: tm: add tm API definitions
   linux-generic: tm: implement traffic manager
   linux-generic: tm: add tm to build
   example: tm: traffic manager example

  configure.ac                                       |    1 +
  example/Makefile.am                                |    2 +-
  example/traffic_mgmt/.gitignore                    |    1 +
  example/traffic_mgmt/Makefile.am                   |    9 +
  example/traffic_mgmt/odp_traffic_mgmt.c            |  781 ++++++
  include/odp.h                                      |    1 +
  include/odp/api/packet.h                           |   69 +
  include/odp/api/traffic_mngr.h                     | 1611 +++++++++++
  platform/linux-generic/Makefile.am                 |   13 +
  .../linux-generic/include/odp/plat/packet_types.h  |   11 +
  .../linux-generic/include/odp/plat/queue_types.h   |    1 +
  .../include/odp/plat/traffic_mngr_types.h          |  185 ++
  platform/linux-generic/include/odp/traffic_mngr.h  |   35 +
  platform/linux-generic/include/odp_internal.h      |    2 +
  .../include/odp_name_table_internal.h              |   61 +
  .../linux-generic/include/odp_packet_internal.h    |    5 +
  .../linux-generic/include/odp_pkt_queue_internal.h |   62 +
  .../linux-generic/include/odp_queue_internal.h     |    6 +
  .../include/odp_sorted_list_internal.h             |   77 +
  .../include/odp_timer_wheel_internal.h             |   68 +
  .../include/odp_traffic_mngr_internal.h            |  324 +++
  platform/linux-generic/odp_init.c                  |    5 +
  platform/linux-generic/odp_name_table.c            | 1367 ++++++++++
  platform/linux-generic/odp_packet_flags.c          |   45 +
  platform/linux-generic/odp_pkt_queue.c             |  379 +++
  platform/linux-generic/odp_queue.c                 |   59 +
  platform/linux-generic/odp_sorted_list.c           |  270 ++
  platform/linux-generic/odp_timer_wheel.c           |  907 +++++++
  platform/linux-generic/odp_traffic_mngr.c          | 2796 ++++++++++++++++++++
  29 files changed, 9152 insertions(+), 1 deletion(-)
  create mode 100644 example/traffic_mgmt/.gitignore
  create mode 100644 example/traffic_mgmt/Makefile.am
  create mode 100644 example/traffic_mgmt/odp_traffic_mgmt.c
  create mode 100644 include/odp/api/traffic_mngr.h
  create mode 100644 
platform/linux-generic/include/odp/plat/traffic_mngr_types.h
  create mode 100644 platform/linux-generic/include/odp/traffic_mngr.h
  create mode 100644 platform/linux-generic/include/odp_name_table_internal.h
  create mode 100644 platform/linux-generic/include/odp_pkt_queue_internal.h
  create mode 100644 platform/linux-generic/include/odp_sorted_list_internal.h
  create mode 100644 platform/linux-generic/include/odp_timer_wheel_internal.h
  create mode 100644 platform/linux-generic/include/odp_traffic_mngr_internal.h
  create mode 100644 platform/linux-generic/odp_name_table.c
  create mode 100644 platform/linux-generic/odp_pkt_queue.c
  create mode 100644 platform/linux-generic/odp_sorted_list.c
  create mode 100644 platform/linux-generic/odp_timer_wheel.c
  create mode 100644 platform/linux-generic/odp_traffic_mngr.c


_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to