Hello Matias,

this test does not test anything. In many validation tests create_pktio() helper exist. I think it's reasonable to just add odp_pktio_print() just after pktio creation in all tests.
So that from log it will be clear which pktio was used for testing.

Thanks,
Maxim.

On 10/28/2015 16:29, Matias Elo wrote:
Signed-off-by: Matias Elo <[email protected]>
---
  test/validation/pktio/pktio.c | 15 +++++++++++++++
  1 file changed, 15 insertions(+)

diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index a746b9a..4b8a73d 100644
--- a/test/validation/pktio/pktio.c
+++ b/test/validation/pktio/pktio.c
@@ -780,6 +780,20 @@ static void pktio_test_start_stop(void)
        }
  }
+static void pktio_test_print(void)
+{
+       int ret;
+
+       odp_pktio_t pktio = create_pktio(iface_name[0],
+                                        ODP_QUEUE_TYPE_SCHED, 0);
+       CU_ASSERT_FATAL(pktio != ODP_PKTIO_INVALID);
+
+       odp_pktio_print(pktio);
+
+       ret = odp_pktio_close(pktio);
+       CU_ASSERT(ret == 0);
+}
+
  static int create_pool(const char *iface, int num)
  {
        char pool_name[ODP_POOL_NAME_LEN];
@@ -891,6 +905,7 @@ odp_testinfo_t pktio_suite_unsegmented[] = {
        ODP_TEST_INFO(pktio_test_mac),
        ODP_TEST_INFO(pktio_test_inq_remdef),
        ODP_TEST_INFO(pktio_test_start_stop),
+       ODP_TEST_INFO(pktio_test_print),
        ODP_TEST_INFO_NULL
  };

_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to