On 30 October 2015 at 12:46, Stuart Haslam <stuart.has...@linaro.org> wrote:
> On Fri, Oct 30, 2015 at 09:38:08AM +0100, Christophe Milard wrote: > > Maybe time to move things around and embrace more than just the > validation > > tests in the platform-agnostic/platform-dependent split? > > reason: > > 1)Mike is now seeing a case where he wants per-platform behaviour for the > > performance tests > > The existing structure could be changed to work with that by adding > another subdirectory under platform/<plat>/test/ to mirror the structure > under test/. > not sure I understand your proposal... could you draw the tree? > > > 2)Gary may see that as well in its isolation work (not really sure :-) ) > > 3)I see some need to be able to have a directory structure within the ODP > > code itself (i.e to move away the test directory from where it is > currently > > located)... E.g. to create a drivers directory. > > Not sure I follow, are you talking about other directories at the same > level as platform/linux-generic/pktio/? If so I don't have a problem > with these living alongside the "test" directory (it's pretty clear it > contains test stuff), but you do? > > > > > proposed new structure: > > > > test/ > > ├── agnostic //contains all platform agnostic test > > I think common would be a better name. > Not sure as 'common' is already used in the validation directory to designate things that are common to different modules. maybe Bill's proposal, 'universal' is better. > > > │ ├── helpers //platform agnostic tests for helpers > > │ ├── perf //platform agnostic performance tests > > │ └── validation //platform agnostic validation tests (1) > > │ ├── crypto //one dir per module > > │ ├── errno > > │ ├── init > > │ ├── packet > > │ ├── pktio > > │ └── pool... > > ├── dpdk //platform dependent tests for dpdk > > │ ├── helpers //platform dependent tests for helpers (2) > > │ ├── perf //platform dependent performance tests (2) > > │ └── validation //platform dependent validation tests (2) (3) > > │ └── pktio > > └── linux-generic //platform dependent tests for linux-generic > > ├── helpers //(2) > > ├── perf //(2) > > └── validation //(2) (3) > > └── pktio > > > > (1) This is where the contents of the current 'validation' directory > would > > be. > > (2) Test are always RUN from these directories > > (and use things from the agnostic side) > > (3) This is where the contents of the current 'platform/<platform>/test' > > directory would be. > > > > Helpers are still a kind of strange animal in my mind. I may be missing > > obvious reason not to include them... > > > > Please comment. > > > > Although I don't fully understand the reasons, no real objection from me > for the general idea. I do think it's good that the platform specific > stuff is currently all kept within is a single well defined part of the > tree, but having two well defined places isn't too bad if it brings real > improvements elsewhere. > > -- > Stuart. >
_______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
