Hi,

On 02/11/15 10:54, Stuart Haslam wrote:
On Fri, Oct 30, 2015 at 06:38:14PM +0000, Zoltan Kiss wrote:
For debug purposes, otherwise it's not trivial to figure out which pktio was
successful.

Signed-off-by: Zoltan Kiss <zoltan.k...@linaro.org>


diff --git a/platform/linux-generic/pktio/socket.c 
b/platform/linux-generic/pktio/socket.c
index 7e30027..66fd9ca 100644
--- a/platform/linux-generic/pktio/socket.c
+++ b/platform/linux-generic/pktio/socket.c
@@ -463,6 +463,7 @@ static int sock_promisc_mode_get(pktio_entry_t *pktio_entry)
  }

  const pktio_if_ops_t sock_mmsg_pktio_ops = {
+       .name = "sock_mmsg",
        .init = NULL,
        .term = NULL,
        .open = sock_mmsg_open,
diff --git a/platform/linux-generic/pktio/socket_mmap.c 
b/platform/linux-generic/pktio/socket_mmap.c
index 35d24c6..cdf221e 100644
--- a/platform/linux-generic/pktio/socket_mmap.c
+++ b/platform/linux-generic/pktio/socket_mmap.c
@@ -516,6 +516,7 @@ static int sock_mmap_promisc_mode_get(pktio_entry_t 
*pktio_entry)
  }

  const pktio_if_ops_t sock_mmap_pktio_ops = {
+       .name = "sock_mmap",
        .init = NULL,
        .term = NULL,
        .open = sock_mmap_open,

How about "socket" and "socket_mmap"? that way the names match the
source file names.

Now that I wanted to update the patch, I found that although the file names use "socket", all the function names use "sock". Which one should we align to?

Zoli
_______________________________________________
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to