Hmmm - runtime init is another possibility I hadn't fully considered. My code already checks for isolation support. Presumably I could set a runtime global flag or flags to indicate to all interested parties just what isolation features were enabled and then select optimal behavior based on runtime configuration. The tricky part is deciding what the scope of the flags should be... odp_pktio_perf.c seems to be linux-specific already and could conceivably use flags defined in the linux isolation helpers to determine appropriate runtime behavior. But in some cases - eg. odp_cpumask_default_worker() and odp_cpumask_default_control() - the behavior of the linux-generic implementation itself should perhaps be modified rather than substituting a helper call for the linux-generic one? Coming late to the party I've missed out on the discussions and consensus as to where to draw the lines of abstraction, transparency, and least common denominator here. To what extent should linux-generic itself handle isolation support (or the lack of it) in an application-transparent manner? It seems a somewhat moot point for test applications intended to run on a linux development host - but what about the wider scope of end-user applications. Even if linux-generic itself isn't intended to be performance-oriented there may be a case for including isolation support there.
On Fri, Nov 13, 2015 at 1:49 PM, Nicolas Morey-Chaisemartin < [email protected]> wrote: > > > On 11/13/2015 07:56 PM, Mike Holmes wrote: > > > > On 13 November 2015 at 13:51, Gary Robertson <[email protected]> > wrote: > >> Oops - clicked the wrong reply option. >> >> Nicolas raises an excellent point. I think at least a configuration >> option may be needed to enable or disable isolation. >> > > I think that ./configure should check for the support and it if it is > available provided the configure option --enable-test-isolated, this is how > nearly all our other optional capabilities work. In this case if support is > there the default would be to enable --enable-test-isolated > > It is. But the latest talk about RPM packaging and runtime compatibility > tends to move thing another way. > I guess we want to move as many things as possible to runtime init so a > single compile binary can leverage the best performance on whatever > platform it is running (as long as it is ABI compliant) > > Nicolas > >
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
