On 2015-11-16 10:29, Maxim Uvarov wrote: > On 11/13/2015 22:53, Mike Holmes wrote: > > > > > >On 13 November 2015 at 14:37, Maxim Uvarov <[email protected] > ><mailto:[email protected]>> wrote: > > > > I know that patch is on the list. > > > > > > > >Then why take the broken patches ? > > It was merged after 1.4.1 from next branch. Where some queued patches were. > 1.4.1 tag does not have any doxygen warning. And I think I do not test each > patch for doxygen. Or tests does not trap if there is warning. At least I > needed to check that. I use the same scripts as CI has and all CI tests > passed. We also need to add doxygen check to CI. > > > >Master can never take something that is know to introduce and regressions, > >the patches have to resent or the maintainer merges patches. > >Apply and build must _always_ pass clean for any patch accepted into any > >of our branches. > > > > Does apply-and-build.sh capture that doxygen warnings?
Yes, at least for me, I just tried it again... > In my case > apply-and-build.sh does not work at all. I.e. I created a patch from top > commit put it to ~/incoming directory. Run script. And I see that > apply-and-build.sh tried to apply patch, failed, did it 3 way, failed, then > it started to compile and said that everything is ok. That feels strange, do you have other patches in ~/incoming? Try to do: $ PATCH_DIR=/path/to/wherever/you/have/the/new/patch ./apply-and-build.sh Cheers, Anders > I definitely can not > use such tools effective. For testing I use git am hook with validates each > patch after I applied it and fixed rejects. I see that build.sh generates > doxygen and user html. But it does not trap if there is error. Probably to > extend that is easiest way to not have such warnings in future. > > Maxim. > > > > > > > > > Maxim. > > > > On 13 November 2015 at 22:24, Mike Holmes <[email protected] > > <mailto:[email protected]>> wrote: > > > > Master is broken, we need to back out the table patch as it > > should not have been merged. > > > > rm -rf doc/output > > SRCDIR='.' PROJECT='OpenDataPlane' DOCDIR='doc/output' > > VERSION='1.4.1.0' WITH_PLATFORM='linux-generic' > > PERL_PATH='/usr/bin/perl' HAVE_DOT='NO' GENERATE_MAN='NO' > > GENERATE_RTF='NO' GENERATE_XML='NO' GENERATE_HTMLHELP='NO' > > GENERATE_CHI='NO' GENERATE_HTML='YES' GENERATE_LATEX='YES' > > /usr/bin/doxygen ./doc/doxygen.cfg > > /home/mike/git/odp/helper/include/odp/helper/table.h:205: > > warning: Compound odp_table_ops is not documented. > > /home/mike/git/odp/helper/include/odp/helper/table.h:78: > > warning: Member ODPH_TABLE_NAME_LEN (macro definition) of file > > table.h is not documented. > > /home/mike/git/odp/helper/include/odp/helper/table.h:80: > > warning: Member odph_table_t (typedef) of file table.h is not > > documented. > > /home/mike/git/odp/helper/include/odp/helper/table.h:215: > > warning: Member odph_table_ops_t (typedef) of file table.h is > > not documented. > > /home/mike/git/odp/helper/include/odp/helper/table.h:16: > > warning: Unsupported xml/html tag <Use> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:25: > > warning: Unsupported xml/html tag <key> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:26: > > warning: Unsupported xml/html tag <associated> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:27: > > warning: Unsupported xml/html tag <Algorithm> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:29: > > warning: Unsupported xml/html tag <Use> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:34: > > warning: Unsupported xml/html tag <Key> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:35: > > warning: Unsupported xml/html tag <Associated> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:36: > > warning: Unsupported xml/html tag <Algorithm> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:39: > > warning: Unsupported xml/html tag <Use> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:45: > > warning: Unsupported xml/html tag <key> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:46: > > warning: Unsupported xml/html tag <associated> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:51: > > warning: Unsupported xml/html tag <algorithm> found > > /home/mike/git/odp/helper/include/odp/helper/table.h:214: > > warning: Member f_remove (variable) of class odp_table_ops is > > not documented. > > > > > > On 13 November 2015 at 07:42, Maxim Uvarov > > <[email protected] <mailto:[email protected]>> wrote: > > > > 1.4.1 is released with critical fixes to ordered queues, > > pktio and l2fwd performance improvement, > > > > Note: no api changes from 1.4.0 > > > > +opendataplane (1.4.1.0-1) unstable; urgency=low > > + * Validation > > + - pktio: test transmit error recovery > > + - schedule: add chaos test > > + - check return code from odp_queue_lock_count() > > + - scheduler: test ordered queue reorder processing > > + - pktio: initialize queue parameters correctly > > + - pktio: test for transmit error handling > > + - pktio: add support for direct receive > > + - pktio: pass interface index rather than name > > + - pktio: fix start_stop test > > + - test: l2fwd: separate rx and tx drop counters > > + - test: l2fwd: increase burst size > > + - test: l2fwd: optimize statistics usage > > + - test: l2fwd: optimize queue mode > > + - test: l2fwd: start pktios after worker thread create > > + - test: l2fwd: added option to disable error check > > + - example/ipsec: Increase ip_data_len for Tunnel mode > > + - example: ipsec: check push_tail return code > > + * General: > > + - linux-generic: pktio: handle transmit errors > > correctly > > + - pktio socket_mmap: recover from transmit errors > > but 1890 > > + - pktio: increase MTU of loop interface > > + - ordered queues: fix race condition during order > > release > > + and out of order. > > + - configure: move HAVE_PCAP AM_CONDITIONAL to > > configure.ac <http://configure.ac> > > + * ODP helper: > > + - linux: checkpatch cleaning for helper/linux.c > > + - linux: examine the cause for child process > > termination > > + - linux: request SIGTERM if parent process dies > > > > Best regards, > > Maxim. > > > > _______________________________________________ > > lng-odp mailing list > > [email protected] <mailto:[email protected]> > > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > > > > > > -- Mike Holmes > > Technical Manager - Linaro Networking Group > > Linaro.org <http://www.linaro.org/>***│ *Open source software > > for ARM SoCs > > > > > > > > > > > >-- > >Mike Holmes > >Technical Manager - Linaro Networking Group > >Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs > > > > _______________________________________________ > lng-odp mailing list > [email protected] > https://lists.linaro.org/mailman/listinfo/lng-odp -- Anders Roxell [email protected] M: +46 709 71 42 85 | IRC: roxell _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
