On 08.12.2015 17:38, Stuart Haslam wrote: > On Tue, Dec 08, 2015 at 12:21:06PM +0000, Elo, Matias (Nokia - FI/Espoo) > wrote: >> Hi Ilya, >> >> I had completely missed your previous patch. You could also remove the two >> errno value checks in pktio_test_send_failure(). They are not defined in the >> API, so they should not be tested. >> >> -Matias >> > > It realise it's back-to-front, but IMO it would be better to document > that the errno must be set. >
I agree with that. There is so little set of functions, according to documentation, sets up errno. My opinion is that almost all functions should set it on errors, otherwise it useless. Best regards, Ilya Maximets. _______________________________________________ lng-odp mailing list lng-odp@lists.linaro.org https://lists.linaro.org/mailman/listinfo/lng-odp
