Yes, we'll keep them. I wasn't involved in the delete decision. You can add "@retval 0 on failure" to the API spec.
/** * Current CPU frequency in Hz * * Returns current frequency of this CPU * * @return CPU frequency in Hz * @retval 0 on failure */ uint64_t odp_cpu_hz(void); -Petri > -----Original Message----- > From: EXT Hongbo Zhang [mailto:[email protected]] > Sent: Thursday, December 17, 2015 1:05 PM > To: Savolainen, Petri (Nokia - FI/Espoo) > Cc: EXT [email protected]; [email protected]; > [email protected] > Subject: Re: [PATCH API-NEXT 00/10] move CPU frequency APIs for linux- > generic > > Hmm, there were changes of decision how to handle these APIs. > > Here it is mentioned to delete. > https://collaborate.linaro.org/pages/viewpage.action?title=2015-12- > 16+ODP+ARCH&spaceKey=LNG > > Do you mean now the final official decision is to keep them, right? > > "return 0 on failure", this can be fixed soon, and I planed to > separate platform implementation into their own arch files too. > > > On 17 December 2015 at 18:55, Savolainen, Petri (Nokia - FI/Espoo) > <[email protected]> wrote: > > Instead of removing these calls, we decided in an ARCH call this week > that odp_cpu_hz*() calls can return 0 on failure (e.g. when could not read > CPU hz on a platform). > > > > -Petri > > > >> -----Original Message----- > >> From: EXT [email protected] > [mailto:[email protected]] > >> Sent: Thursday, December 17, 2015 12:47 PM > >> To: [email protected] > >> Cc: [email protected]; [email protected]; Hongbo > Zhang > >> Subject: [PATCH API-NEXT 00/10] move CPU frequency APIs for linux- > generic > >> > >> From: Hongbo Zhang <[email protected]> > >> > >> This patch series move the public CPU frequecy APIs for linux-generic > >> internal > >> only. All references except for linux-geneic are deleted, and the > >> functions > >> declaration are moved to linux-generic headers. > >> > >> There should be further clean-ups after this patch set being merged, > for > >> example, separate platform specific implementations into there own > >> platform > >> files, and fix the frequency dummy data on ARM etc. > >> > >> Hongbo Zhang (10): > >> validation: system: remove validation of odp_cpu_hz() > >> validation: system: remove validation of odp_cpu_hz_id() > >> validation: system: remove validation of odp_cpu_hz_max() > >> validation: system: remove validation of odp_cpu_hz_max_id() > >> example: remove reference of odp_cpu_hz_max() > >> test: remove reference of odp_cpu_hz_max() > >> api: sysinfo: move odp_cpu_hz() for linux-generic internal > >> api: sysinfo: move odp_cpu_hz_id() for linux-generic internal > >> api: sysinfo: move odp_cpu_hz_max() for linux-generic internal > >> api: sysinfo: move odp_cpu_hz_max_id() for linux-generic internal > >> > >> example/classifier/odp_classifier.c | 4 +-- > >> example/generator/odp_generator.c | 3 +- > >> example/ipsec/odp_ipsec.c | 3 +- > >> example/packet/odp_pktio.c | 3 +- > >> example/timer/odp_timer_test.c | 2 -- > >> include/odp/api/cpu.h | 40 ------------------------ > >> platform/linux-generic/include/odp/cpu.h | 20 ++++++++++++ > >> test/api_test/odp_common.c | 1 - > >> test/performance/odp_atomic.c | 1 - > >> test/performance/odp_l2fwd.c | 3 +- > >> test/performance/odp_scheduling.c | 8 ----- > >> test/validation/system/system.c | 52 ------------------------ > --- > >> ----- > >> test/validation/system/system.h | 4 --- > >> 13 files changed, 25 insertions(+), 119 deletions(-) > >> > >> -- > >> 2.1.4 > >> > > _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
