The tests-validation.env file lists the test binaries/scripts to be run
during post-install testing, but the Makefile dependencies are wrong so
it gets created once and never updated. This means the following
sequence doesn't actually peform testing as expected -

./configure
make
./configure --enable-test-vald --with-testdir --prefix=$(pwd)/mytests
make install installcheck

As the tests-environment.env file generated during the first make (with
test-vald disabled) isn't updated.

Signed-off-by: Stuart Haslam <[email protected]>
---
 platform/linux-generic/test/Makefile.am | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/platform/linux-generic/test/Makefile.am 
b/platform/linux-generic/test/Makefile.am
index e629872..8c35c15 100644
--- a/platform/linux-generic/test/Makefile.am
+++ b/platform/linux-generic/test/Makefile.am
@@ -36,14 +36,19 @@ TESTS += pktio/pktio_run_pcap
 endif
 endif
 
-dist_check_SCRIPTS = run-test tests-validation.env $(LOG_COMPILER)
+TEST_ENV = tests-validation.env
+
+dist_check_SCRIPTS = run-test $(TEST_ENV) $(LOG_COMPILER)
 
 test_SCRIPTS = $(dist_check_SCRIPTS)
 
-tests-validation.env:
-       echo "TESTS=\"$(TESTS)\""    > $@
-       echo "$(TESTS_ENVIRONMENT)" >> $@
-       echo "$(LOG_COMPILER)"      >> $@
+$(TEST_ENV): validation-test-env
+
+.PHONY: validation-test-env
+validation-test-env:
+       echo "TESTS=\"$(TESTS)\""    > $(TEST_ENV)
+       echo "$(TESTS_ENVIRONMENT)" >> $(TEST_ENV)
+       echo "$(LOG_COMPILER)"      >> $(TEST_ENV)
 
 if test_installdir
 installcheck-local:
-- 
2.1.1

_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp

Reply via email to