On Thu, Jan 28, 2016 at 2:14 AM, Savolainen, Petri (Nokia - FI/Espoo) < [email protected]> wrote:
> > > > -----Original Message----- > > From: lng-odp [mailto:[email protected]] On Behalf Of EXT > > Bill Fischofer > > Sent: Wednesday, January 27, 2016 10:12 PM > > To: [email protected] > > Subject: [lng-odp] [API-NEXT PATCHv2 1/6] api: packet: add bcast/mcast > > parse documentation > > > > Signed-off-by: Bill Fischofer <[email protected]> > > --- > > include/odp/api/packet_flags.h | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/include/odp/api/packet_flags.h > > b/include/odp/api/packet_flags.h > > index 65fd3ce..a9fd07a 100644 > > --- a/include/odp/api/packet_flags.h > > +++ b/include/odp/api/packet_flags.h > > @@ -109,6 +109,9 @@ int odp_packet_has_eth(odp_packet_t pkt); > > /** > > * Check for Ethernet broadcast address > > * > > + * ODP recognizes the destination MAC address as broadcast if it begins > > + * FF:FF: > > I think it's safer to specify all ones (FF:FF:FF:FF:FF:FF) since all HW > parser would consider that bcast and application does not need to check > last 4 bytes for FF:FF:FF:FF. > OK. I didn't want to incur the overhead but can see the value of that in the spec. I'll send a v3 with that correction. > > Otherwise the patch set looks good. > > -Petri > >
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
