This looks good, however PLAIN doesn't seem very intuitive as it's not descriptive of how the queue behaves. How about simply QUEUE_TYPE_UNSCHED to contrast with QUEUE_TYPE_SCHED? The real distinction here is whether the ODP scheduler or the application is managing the queue, i.e., whether the queue is scheduled or unscheduled. Encoding that in the name would make that distinction very clear. With the move of the type parameter into the odp_queue_param_t struct, omitting this struct on odp_queue_create() would default to creating an unscheduled queue.
Other than that, for this series: Reviewed-and-tested-by: Bill Fischofer <[email protected]> On Thu, Jan 28, 2016 at 7:24 AM, Petri Savolainen < [email protected]> wrote: > This patch set renames queue types and pktio modes with commonly used and > descriptive terms. Type of odp_queue_type_t is defined as enum and included > into queue parameters. Queue type and defines parameter usage (which > params are > considered e.g. in queue creation), and is inline with other create APIs > (pool, > timer, tm, ...). > > These modifications are preparation for removal of PKTIN and PKOUT queue > types, > and the single queue pktio API (odp_pktio_inq_setdef(), etc). > > > > Petri Savolainen (6): > api: sched: rename SCHED_SYNC_NONE to _PARALLEL > api: queue: rename QUEUE_TYPE_POLL to _PLAIN > api: pktio: rename pktio modes > api: queue: define queue type as enum > api: queue: moved queue type into queue parameters > linux-generic: use term plain queue instead of poll > > example/classifier/odp_classifier.c | 16 ++-- > example/generator/odp_generator.c | 9 ++- > example/ipsec/odp_ipsec.c | 43 ++++++----- > example/packet/odp_pktio.c | 14 ++-- > example/time/time_global_test.c | 8 +- > example/timer/odp_timer_test.c | 5 +- > include/odp/api/packet_io.h | 26 +++---- > include/odp/api/queue.h | 68 +++++++++------- > include/odp/api/schedule_types.h | 12 +-- > .../linux-generic/include/odp/plat/queue_types.h | 8 -- > .../include/odp/plat/schedule_types.h | 2 +- > platform/linux-generic/odp_packet_io.c | 37 +++++---- > platform/linux-generic/odp_queue.c | 13 +++- > platform/linux-generic/odp_schedule.c | 5 +- > platform/linux-generic/pktio/loop.c | 2 +- > platform/linux-generic/pktio/netmap.c | 3 +- > test/performance/odp_l2fwd.c | 54 ++++++------- > test/performance/odp_pktio_perf.c | 32 ++++---- > test/performance/odp_scheduling.c | 20 ++--- > .../classification/odp_classification_common.c | 11 +-- > .../classification/odp_classification_test_pmr.c | 13 ++-- > .../classification/odp_classification_tests.c | 51 ++++++------ > test/validation/crypto/crypto.c | 3 +- > test/validation/pktio/pktio.c | 90 > +++++++++++----------- > test/validation/pktio/pktio.h | 4 +- > test/validation/queue/queue.c | 48 ++++++------ > test/validation/scheduler/scheduler.c | 89 > +++++++++++---------- > test/validation/timer/timer.c | 6 +- > 28 files changed, 353 insertions(+), 339 deletions(-) > > -- > 2.6.3 > > _______________________________________________ > lng-odp mailing list > [email protected] > https://lists.linaro.org/mailman/listinfo/lng-odp >
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
