Bill,
clang build fails on warnings:
CC odp_packet.lo
odp_packet.c:965:33: error: cast from 'const odph_ethhdr_t *' to 'const
uint16_t *' (aka 'const unsigned short *') increases required alignment
from 1 to 2 [-Werror,-Wcast-align]
macaddr2 = odp_be_to_cpu_16(*((const uint16_t *)eth + 1));
^~~~~~~~~~~~~~~~~~~~~
odp_packet.c:966:33: error: cast from 'const odph_ethhdr_t *' to 'const
uint16_t *' (aka 'const unsigned short *') increases required alignment
from 1 to 2 [-Werror,-Wcast-align]
macaddr4 = odp_be_to_cpu_16(*((const uint16_t *)eth + 2));
On 02/08/2016 21:04, Bill Fischofer wrote:
Good point. I'll do that in future. Thanks.
On Mon, Feb 8, 2016 at 12:03 PM, Maxim Uvarov <[email protected]
<mailto:[email protected]>> wrote:
On 02/08/2016 21:01, Bill Fischofer wrote:
The series was reviewed by Petri. The last tweak was just a
typo in the documentation patch.
Ok, will merge it then. It's better to include reviews to commit
message in next versions if you don't
ask for one more review.
Maxim.
On Mon, Feb 8, 2016 at 11:58 AM, Maxim Uvarov
<[email protected] <mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>> wrote:
On 02/08/2016 20:56, Bill Fischofer wrote:
ping. This has been reviewed. v5 should be merged.
reviewed all patches or 5 and 6 only?
Maxim.
On Thu, Jan 28, 2016 at 9:04 AM, Bill Fischofer
<[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
<mailto:[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>>> wrote:
Changes for v5
- Correct typos in user guide changes
Changes for v4
- Correct implementation of eth_bcast check
Changes for v3
- Changed Ethernet bcast spec to recognize
FF:FF:FF:FF:FF:FF
Changes for v2:
- Add parse criteria to API documentation for
bcast/mcast
flags
- Implement revised parse criteria
This patch series adds the implementation, CUnit
validation tests, and
documentation for the addition of the broadcast
and multicast
packet metadata
APIs.
This series must be applied following patch
http://patches.opendataplane.org/patch/4653/
Bill Fischofer (6):
api: packet: add bcast/mcast parse documentation
linux-generic: packet: implement broadcast and
multicast
metadata
flags
linux-generic: packet: implement parser
extensions for
broadcast and
multicast
validataion: packet: add tests for broadcast and
multicast flags
documentation: userguide: add images for packet
processing
documentation: userguide: add packet processing
description
doc/images/packet.svg | 4 +
doc/images/segment.svg | 4 +
doc/users-guide/users-guide.adoc | 121
+++++++++++++++++++++
include/odp/api/packet_flags.h | 16 +++
.../linux-generic/include/odp_packet_internal.h | 4 +
platform/linux-generic/odp_packet.c | 41 +++++--
platform/linux-generic/odp_packet_flags.c | 40 +++++++
test/validation/packet/packet.c | 9 +-
8 files changed, 227 insertions(+), 12 deletions(-)
create mode 100644 doc/images/packet.svg
create mode 100644 doc/images/segment.svg
--
2.5.0
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp
