Merged,
Maxim.
On 02/19/16 15:04, Tilli, Juha-Matti (Nokia - FI/Espoo) wrote:
Ping.
I would really like to get this patch in because currently odp_l2fwd fails for
me every single time after the netmap optimizations done by Matias Elo. Because
this is a really simple patch and has been reviewed by Matias and tested by two
persons (Matias and me), I guess there should be no objection to merging.
The only harm done is in the case when the link is actually down, and then getting the "link
down" status takes 10 seconds instead of 5 seconds. But that is a really rare case, and there
is no way to avoid that if getting the "link up" status may take longer than 5 seconds.
-----Original Message-----
From: Juha-Matti Tilli [mailto:[email protected]]
Sent: Friday, February 12, 2016 5:13 PM
To: [email protected]
Cc: Tilli, Juha-Matti (Nokia - FI/Espoo)
Subject: [PATCH] linux-generic: netmap: bump up link wait timeout to 10 secs
In some environments, waiting only for 5 seconds for the link is not
enough. The problem is that the link wait timeouts, and thus startup of
the application fails.
Ten seconds seems to be a safe compromise. It is high enough to work on my
test system reliably, yet low enough that it shouldn't cause excessive
delays to get an error in the case that the link is actually down.
Signed-off-by: Juha-Matti Tilli <[email protected]>
Reviewed-and-tested-by: Matias Elo <[email protected]>
---
platform/linux-generic/pktio/netmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/platform/linux-generic/pktio/netmap.c
b/platform/linux-generic/pktio/netmap.c
index 9e3defe..8eadfde 100644
--- a/platform/linux-generic/pktio/netmap.c
+++ b/platform/linux-generic/pktio/netmap.c
@@ -32,7 +32,7 @@
#define NETMAP_WITH_LIBS
#include <net/netmap_user.h>
-#define NM_WAIT_TIMEOUT 5 /* netmap_wait_for_link() timeout in seconds */
+#define NM_WAIT_TIMEOUT 10 /* netmap_wait_for_link() timeout in seconds */
#define NM_INJECT_RETRIES 10
static int netmap_stats_reset(pktio_entry_t *pktio_entry);
_______________________________________________
lng-odp mailing list
[email protected]
https://lists.linaro.org/mailman/listinfo/lng-odp
